Remove active games when challenge canceled#1167
Merged
AttackingOrDefending merged 1 commit intoDec 23, 2025
Merged
Conversation
AttackingOrDefending
approved these changes
Dec 23, 2025
Member
|
If we get more bugs with |
54e3778
into
lichess-bot-devs:master
23 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1166
Type of pull request:
Description:
If a challenge is accepted by a bot, but the challenge is canceled before the game starts, then the game ID remains in the
active_gamesset and will never be removed. This effectively reduces the number of simultaneous games a bot can play by one each time it happens. This change removes the game ID fromactive_gameswhen a challenge is canceled.Related Issues:
Fixes #1166
Checklist:
Screenshots/logs (if applicable):