Improved blocklist parsing robustness and added comprehensive tests#1168
Merged
AttackingOrDefending merged 2 commits intoDec 29, 2025
Conversation
- Added 15-second timeout to HTTP requests to prevent indefinite hanging - Used splitlines() to handle various line ending formats (CRLF, LF, CR) - Filtered empty usernames using walrus operator for better efficiency - Added test coverage for OnlineBlocklist.refresh() method - Added tests for error handling, ETag caching, and edge cases
MarkZH
approved these changes
Dec 29, 2025
AttackingOrDefending
approved these changes
Dec 29, 2025
AttackingOrDefending
merged commit fcaa276
into
lichess-bot-devs:master
23 checks passed
bayta-darell-1400
added a commit
to bayta-darell-1400/lichess-bot
that referenced
this pull request
Dec 30, 2025
…ichess-bot-devs#1168) * Improved blocklist parsing robustness and added comprehensive tests - Added 15-second timeout to HTTP requests to prevent indefinite hanging - Used splitlines() to handle various line ending formats (CRLF, LF, CR) - Filtered empty usernames using walrus operator for better efficiency - Added test coverage for OnlineBlocklist.refresh() method - Added tests for error handling, ETag caching, and edge cases * lint fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of pull request:
Description:
lib/blocklist.pyis now 100%.Related Issues:
ref #920
Checklist:
Screenshots/logs (if applicable):