Fix mobile scrolling for FIDE player tables#20522
Open
Mheet wants to merge 3 commits into
Open
Conversation
Author
|
Hi! I recreated the branch cleanly from the latest upstream master and pushed a fresh PR with only the However, CI still seems to fail before reaching my changes due to:
Since this is unrelated to the modified file, I wanted to check whether this is a known CI/build issue on the current upstream branch. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Fixes mobile scrolling issues on the FIDE Players page.
On mobiles (web page), the tables overflowed horizontally while the page body used
overflow-x: hidden, causing some columns/content to become inaccessible. To be precise, In Broadcasts>Fide Players the page was wrapped, causing some columns to be inaccessible, like blitz and rapid rating, etcThis change wraps the tables with the existing
slist-wrapperresponsive container already used elsewhere in Lichess for horizontally scrollable tables.Testing
I tested this locally on WSL2 using the Lichess development environment.
Verified in Chrome DevTools mobile emulation:
Confirmed that:
Notes
I initially investigated the issue through Chrome DevTools responsive mode and traced the problem to overflow handling on mobile layouts before implementing the wrapper-based fix.
Before (Current UI bug)
Fix (Current UI)