Skip to content

Fix mobile scrolling for FIDE player tables#20522

Open
Mheet wants to merge 3 commits into
lichess-org:masterfrom
Mheet:fix-fide-player-mobile-scroll-clean
Open

Fix mobile scrolling for FIDE player tables#20522
Mheet wants to merge 3 commits into
lichess-org:masterfrom
Mheet:fix-fide-player-mobile-scroll-clean

Conversation

@Mheet
Copy link
Copy Markdown

@Mheet Mheet commented May 23, 2026

Summary

Fixes mobile scrolling issues on the FIDE Players page.

On mobiles (web page), the tables overflowed horizontally while the page body used overflow-x: hidden, causing some columns/content to become inaccessible. To be precise, In Broadcasts>Fide Players the page was wrapped, causing some columns to be inaccessible, like blitz and rapid rating, etc

This change wraps the tables with the existing slist-wrapper responsive container already used elsewhere in Lichess for horizontally scrollable tables.

Testing

I tested this locally on WSL2 using the Lichess development environment.

Verified in Chrome DevTools mobile emulation:

  • iPhone 12 Pro

Confirmed that:

  • tables are horizontally scrollable on mobile
  • content is no longer clipped/cut off
  • desktop layout remains unchanged

Notes

I initially investigated the issue through Chrome DevTools responsive mode and traced the problem to overflow handling on mobile layouts before implementing the wrapper-based fix.

image

Before (Current UI bug)

image

Fix (Current UI)

@Mheet
Copy link
Copy Markdown
Author

Mheet commented May 23, 2026

Hi! I recreated the branch cleanly from the latest upstream master and pushed a fresh PR with only the FidePlayerUi.scala mobile scrolling wrapper change.

However, CI still seems to fail before reaching my changes due to:

build.sbt:512: value generateForwardRouter is not a member of object play.sbt.routes.RoutesKeys

Since this is unrelated to the modified file, I wanted to check whether this is a known CI/build issue on the current upstream branch.

@fitztrev
Copy link
Copy Markdown
Member

Looks like there's some space showing up next to the table:

image

In your local environment, you can login as superadmin, visit /dev/cli and then run fide player sync to populate data for the table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants