Study chapter management - Delete, rename, change orientation#2912
Open
CloudyDino wants to merge 6 commits into
Open
Study chapter management - Delete, rename, change orientation#2912CloudyDino wants to merge 6 commits into
CloudyDino wants to merge 6 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
Thanks for taking care of this. I'm focusing on the next release so there will be a delay before I review this fyi. |
The chapter settings menu referenced widget.id, but _StudyChaptersMenu exposes `options`, not `id`. Update the four call sites to use studyControllerProvider(widget.options) to match the rest of the widget. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
I have not forgotten you @CloudyDino ; and this PR is definitely wanted. But this is a complex subject, and this PR is only the beginning of a lot of work. For now I don't have the time to deal with it, as we have other priorities. But I will eventually. Sorry for the delay and thank you for your patience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Study chapter management
Adds chapter management actions for study contributors. When a user has write access to a study, each chapter in the chapter list now shows a settings icon with options to:
All operations use the lichess study WebSocket protocol (
deleteChapterandeditChapterevents), matching how the web client handles these actions.Implementation details
StudyController.deleteChaptersends the chapter ID directly as the socket data payload, then navigates to an adjacent chapter. When deleting the last chapter, it waits briefly for the server to create the auto-generated empty replacement before re-fetching.StudyController.editChaptersends the fulleditChapterpayload (id,name,orientation,mode,description) and optimistically updates local state.Related issues
These issues request chapter creation, which is not included here, but this PR builds the chapter management UI that creation can be added to.
Files changed
lib/src/model/study/study_controller.dart—deleteChapterandeditChaptermethodslib/src/view/study/study_bottom_bar.dart— Settings cog icon, action sheet, rename dialog, orientation pickerTesting done
Android.Testing_compressed.webm