Add delay clock modes and unify local clock setup UI#3122
Conversation
|
Hey I like that there is less going on the clock toolbar and I'm in favor of some of your unifying Few questions and feedbacks if you don't mind: Having a little trouble envisioning what you mean without a submit button. Can you share a screenshot for these bullets or better yet perhaps add a video for the otb changes as well? I like the unified order for the clock settings for all the tools. One other slight reorder I considered is rated before side since rated influences if the side option even exists. Such as on 'challenge a friend' and 'correspondence' screens from the play menu. But my personal rebuttal to myself is that for the correspondence play screen, the side option animates in above when the toggle is toggled. If they were in reverse order, I assume it wouldn't be as pretty because then the rated toggle would be included in the bump-up. Not sure if anything made any sense or if you had any personal opinions on this one. One other idea, as you heard I was in favor of decluttering the clock toolbar. What are your thoughts to bringing sound and/or the rotation button into the gear settings? I can go either way but figured it was worth a shout of consideration. Lastly, I can create a separate pr later but is it somewhat easy to eventually bring in the other clock options that I mentioned in the previous ticket? |
I like the unified design changes and text. I am not so sure I love losing the submit button. Just because I adjust the toggle doesn't mean I want that new time control applied . |
|
Also, I'm presuming this will fix #1905 |


Summary
Adds simple delay and Bronstein delay support to the standalone Clock tool, while keeping increment as the default mode.
The changes are scoped to local/offline clock setup and do not affect server-backed online time controls.
Main areas changed:
lib/src/model/clock/clock_tool_controller.dartlib/src/view/clock/clock_tool_settings_modal.dartlib/src/view/clock/clock_settings.dartlib/src/view/clock/clock_tool_screen.dartlib/src/view/clock/custom_clock_settings.dartlib/src/model/over_the_board/over_the_board_preferences.dartrealTimetoclock, with migration for existing preferences.lib/src/view/over_the_board/configure_over_the_board_game.dartClockandUnlimited.lib/src/view/offline_computer/offline_computer_game_screen.dartAI assistance
This PR was developed with assistance from ChatGPT/Codex. I reviewed and tested the changes manually, and I understand the submitted code.
Demo
Screen_recording_20260506_134420.webm