fix(providers): address SambaNova and Nebius review feedback

Author: olddonkey

tests/sambanova-nebius-provider.test.ts

@@ -90,7 +90,9 @@ describe("SambaNova and Nebius providers", () => {
       dashboardUrl: PROVIDERS.sambanova.dashboardUrl,
       liveModels: true,
       preserveCustomDestination: true,
+      apiKeyValidation: "unknown",
       parallelToolCalls: false,
+      reasoningEfforts: [],
       modelDiscovery: {
         path: "models",
         maxResponseBytes: 131_072,
@@ -109,6 +111,7 @@ describe("SambaNova and Nebius providers", () => {
       liveModels: true,
       preserveCustomDestination: true,
       parallelToolCalls: false,
+      reasoningEfforts: [],
       modelDiscovery: {
         path: "models",
         query: { verbose: "true" },
@@ -133,6 +136,7 @@ describe("SambaNova and Nebius providers", () => {
         baseUrl: provider.baseUrl,
         dashboardUrl: provider.dashboardUrl,
         liveModels: true,
+        ...(id === "sambanova" ? { apiKeyValidation: "unknown" } : {}),
       });
       expect(buildInitProviders().find(row => row.id === id)).toMatchObject({
         kind: "key",
@@ -151,34 +155,52 @@ describe("SambaNova and Nebius providers", () => {
         authMode: "key",
         liveModels: true,
         parallelToolCalls: false,
+        reasoningEfforts: [],
       });
+      expect(seed).not.toHaveProperty("apiKeyValidation");
       expect(seed).not.toHaveProperty("modelDiscovery");
       expect(seed).not.toHaveProperty("preserveCustomDestination");
       expect(KEY_LOGIN_PROVIDERS[id]).not.toHaveProperty("modelDiscovery");
       expect(KEY_LOGIN_PROVIDERS[id]).not.toHaveProperty("preserveCustomDestination");
     }
   });
 
-  test("lists and validates models through each registry-owned endpoint", async () => {
+  test("builds each registry-owned models request and validates the authenticated Nebius catalog", async () => {
     for (const id of ["sambanova", "nebius"] as const) {
       const provider = PROVIDERS[id];
       expect(buildModelsRequest(providerConfig(id).providers[id]!, provider.key, id)).toEqual({
         url: provider.modelsUrl,
         headers: { Authorization: `Bearer ${provider.key}` },
       });
+    }
 
-      globalThis.fetch = (async (input, init) => {
-        expect(String(input)).toBe(provider.modelsUrl);
-        expect(new Headers(init?.headers).get("authorization")).toBe(`Bearer ${provider.key}`);
-        expect(init?.redirect).toBe("error");
-        return new Response(provider.fixture, {
-          status: 200,
-          headers: { "content-type": "application/json" },
-        });
-      }) as typeof fetch;
+    const provider = PROVIDERS.nebius;
+    globalThis.fetch = (async (input, init) => {
+      expect(String(input)).toBe(provider.modelsUrl);
+      expect(new Headers(init?.headers).get("authorization")).toBe(`Bearer ${provider.key}`);
+      expect(init?.redirect).toBe("error");
+      return new Response(provider.fixture, {
+        status: 200,
+        headers: { "content-type": "application/json" },
+      });
+    }) as typeof fetch;
 
-      expect(await validateApiKey(id, KEY_LOGIN_PROVIDERS[id]!, provider.key)).toBe(true);
-    }
+    expect(await validateApiKey("nebius", KEY_LOGIN_PROVIDERS.nebius!, provider.key)).toBe(true);
+  });
+
+  test("does not treat SambaNova's public model catalog as proof that a key is valid", async () => {
+    let fetchCalled = false;
+    globalThis.fetch = (async () => {
+      fetchCalled = true;
+      return new Response(SAMBANOVA_FIXTURE, { status: 200 });
+    }) as typeof fetch;
+
+    expect(await validateApiKey(
+      "sambanova",
+      KEY_LOGIN_PROVIDERS.sambanova!,
+      PROVIDERS.sambanova.key,
+    )).toBe("unknown");
+    expect(fetchCalled).toBe(false);
   });
 
   test("filters Nebius mixed rows and preserves model metadata and native ids", async () => {
@@ -220,6 +242,7 @@ describe("SambaNova and Nebius providers", () => {
     expect(sambanovaModels[1]).toMatchObject({
       owned_by: "sambanova",
       contextWindow: 131_072,
+      reasoningEfforts: [],
     });
     expect(nebiusModels.map(row => row.id)).toEqual([
       "meta-llama/Meta-Llama-3.1-8B-Instruct-fast",
@@ -230,6 +253,7 @@ describe("SambaNova and Nebius providers", () => {
       contextWindow: 131_072,
       inputModalities: ["text"],
       capabilities: ["function-calling", "json-mode"],
+      reasoningEfforts: [],
     });
     expect(nebiusModels[1]).toMatchObject({
       contextWindow: 262_144,
@@ -265,14 +289,15 @@ describe("SambaNova and Nebius providers", () => {
           }],
         },
         stream: true,
-        options: {},
+        options: { reasoning: "high" },
       });
       const body = JSON.parse(String(request.body)) as Record<string, unknown>;
 
       expect(request.url).toBe(`${PROVIDERS[providerId].baseUrl}/chat/completions`);
       expect(request.headers.Authorization).toBe(`Bearer ${PROVIDERS[providerId].key}`);
       expect(body.model).toBe(modelId);
       expect(body.parallel_tool_calls).toBe(false);
+      expect(body).not.toHaveProperty("reasoning_effort");
     }
   });