fix(gui): stop the account-pool card from printing its title twice

The Codex account-pool card rendered "Rotation strategy" twice in a row:
once as the card title in CodexPoolStrategySetting, and again as the
select's field label inside the shared AccountPoolStrategyControls. Both
read the same i18n key, so every locale showed the duplicate.

Give the shared control a `strategyLabelHidden` prop and set it on the
Codex card, where the title already names the field. The label element
stays in the tree as `.sr-only` and the select keeps its aria-label, so
the accessible name is unchanged — only the duplicated on-screen text is
gone.

The Anthropic pool card titles itself `anthropicPool.title`, so its
visual label is not a duplicate; the prop defaults to false and leaves
that surface untouched.

No i18n keys were added, renamed, or removed, so all locales stay in
sync, and `.sr-only` already exists in styles.css.

Author: lidge-jun

gui/src/components/AccountPoolStrategyControls.tsx

@@ -16,6 +16,12 @@ export interface AccountPoolStrategyControlsProps {
   disabled?: boolean;
   strategySelectId?: string;
   stickyInputId?: string;
+  /**
+   * Hide the visual strategy label when the surrounding card title already reads
+   * "Rotation strategy". The select keeps its aria-label, so the accessible name
+   * survives while the duplicated on-screen text disappears.
+   */
+  strategyLabelHidden?: boolean;
   onStrategyChange(strategy: AccountPoolStrategy): void;
   onStickyDraftChange(value: string): void;
   onStickyCommit(): void;
@@ -30,6 +36,7 @@ export default function AccountPoolStrategyControls({
   disabled = false,
   strategySelectId = "account-pool-strategy",
   stickyInputId = "account-pool-sticky-limit",
+  strategyLabelHidden = false,
   onStrategyChange,
   onStickyDraftChange,
   onStickyCommit,
@@ -38,7 +45,9 @@ export default function AccountPoolStrategyControls({
   return (
     <div style={{ marginTop: 12 }}>
       <label className="field" style={{ display: "block" }} htmlFor={strategySelectId}>
-        <span className="field-label">{t("accountPool.strategy")}</span>
+        <span className={strategyLabelHidden ? "sr-only" : "field-label"}>
+          {t("accountPool.strategy")}
+        </span>
         <select
           id={strategySelectId}
           className="input"

gui/src/components/CodexPoolStrategySetting.tsx

@@ -122,6 +122,7 @@ export default function CodexPoolStrategySetting({ apiBase }: { apiBase: string
           disabled={saving}
           strategySelectId="codex-pool-strategy"
           stickyInputId="codex-pool-sticky-limit"
+          strategyLabelHidden
           onStrategyChange={(next) => {
             if (next === strategy) return;
             void save({ strategy: next });

gui/tests/account-pool-strategy.test.tsx

@@ -175,6 +175,41 @@ describe("AccountPoolStrategyControls", () => {
     expect(rr).toContain("Sticky successes before rotate");
     expect(rr).toContain('value="2"');
   });
+
+  test("keeps the visual field label by default (Anthropic card has its own title)", () => {
+    const markup = renderToStaticMarkup(
+      <LanguageProvider>
+        <AccountPoolStrategyControls
+          strategy="quota"
+          stickyDraft="1"
+          onStrategyChange={() => {}}
+          onStickyDraftChange={() => {}}
+          onStickyCommit={() => {}}
+        />
+      </LanguageProvider>,
+    );
+    expect(markup).toContain('class="field-label"');
+    expect(markup).not.toContain('class="sr-only"');
+  });
+
+  test("strategyLabelHidden drops the duplicate visual label but keeps the accessible name", () => {
+    const markup = renderToStaticMarkup(
+      <LanguageProvider>
+        <AccountPoolStrategyControls
+          strategy="quota"
+          stickyDraft="1"
+          strategyLabelHidden
+          onStrategyChange={() => {}}
+          onStickyDraftChange={() => {}}
+          onStickyCommit={() => {}}
+        />
+      </LanguageProvider>,
+    );
+    expect(markup).not.toContain('class="field-label"');
+    expect(markup).toContain('class="sr-only"');
+    // The select must still expose an accessible name.
+    expect(markup).toContain('aria-label="Rotation strategy"');
+  });
 });
 
 describe("CodexPoolStrategySetting optimistic strategy select", () => {
@@ -282,4 +317,43 @@ describe("CodexPoolStrategySetting optimistic strategy select", () => {
     expect(select()?.value).toBe("quota");
     expect(host.textContent).toContain("Rotation strategy could not be saved");
   });
+
+  test("renders the card title once, without a duplicate field label", async () => {
+    globalThis.fetch = (async (input: RequestInfo | URL, init?: RequestInit) => {
+      const url = String(input);
+      if (url.endsWith("/api/codex-auth/active") && (!init || init.method === undefined)) {
+        return new Response(JSON.stringify({
+          accountPoolStrategy: "quota",
+          accountPoolStickyLimit: 1,
+        }), { status: 200 });
+      }
+      throw new Error(`unexpected fetch: ${url} ${init?.method ?? "GET"}`);
+    }) as typeof fetch;
+
+    const host = testWindow.document.createElement("div");
+    testWindow.document.body.appendChild(host as never);
+    const { createRoot } = await import("react-dom/client");
+    await act(async () => {
+      mountedRoot = createRoot(host);
+      mountedRoot.render(
+        <LanguageProvider>
+          <CodexPoolStrategySetting apiBase="http://proxy" />
+        </LanguageProvider>,
+      );
+    });
+    await act(async () => { await flush(); });
+
+    // The card title is the only VISIBLE occurrence; the select's label is sr-only.
+    const visible = [...host.querySelectorAll("*")]
+      .filter((el) => !el.classList.contains("sr-only"))
+      .filter((el) => el.children.length === 0)
+      .map((el) => el.textContent?.trim() ?? "")
+      .filter((text) => text === "Rotation strategy");
+    expect(visible).toHaveLength(1);
+    expect(host.querySelector(".field-label")).toBeNull();
+
+    // Accessibility is preserved: the select still has an accessible name.
+    const select = host.querySelector<HTMLSelectElement>("#codex-pool-strategy");
+    expect(select?.getAttribute("aria-label")).toBe("Rotation strategy");
+  });
 });