Skip to content

Commit 3a93a8d

Browse files
authored
Merge pull request #917 from lidge-jun/codex/postmerge-audit-fixes
fix(security): close the agent star-consent bypass found auditing the #892 merge
2 parents 25c2477 + 6542970 commit 3a93a8d

18 files changed

Lines changed: 469 additions & 737 deletions

.gitignore

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,3 +39,10 @@ devlog/**/security-advisory-draft*
3939
# Test-generated artifacts
4040
tests/.tmp-*/
4141
.claude/
42+
43+
# Retired Go native-runtime experiment. `go/` is not part of the build, the
44+
# typecheck, or the test path, and nothing in `src/` imports it. A single file
45+
# from it (go/internal/cli/config_parity.go) has now been committed by a broad
46+
# `git add` three separate times and reached `dev` once — see
47+
# tests/repo-hygiene.test.ts, which fails if any path here becomes tracked again.
48+
go/

AGENTS.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,16 @@ with regression coverage in `tests/startup-prompt.test.ts`,
130130
another action that spends the user's identity, credits, or reputation, gate it
131131
the same way rather than relying on a prompt an agent can answer.
132132

133+
**Be clear about what that enforcement is and is not.** The management endpoint
134+
requires a dashboard session, which stops the casual path — an agent that would
135+
have POSTed there because the endpoint existed, and one holding only the admin
136+
token. It is not a technical barrier against a determined local agent: a process
137+
running as the user can mint its own session from the loopback dashboard
138+
bootstrap, and can skip the proxy entirely by running `gh` itself. Every local
139+
credential is equally reachable by both the browser and the agent, so no check
140+
inside this process can tell them apart. The real boundary is the rule above, and
141+
it binds you regardless of which mechanism is within reach.
142+
133143
## Commands
134144

135145
```bash

0 commit comments

Comments
 (0)