Skip to content

Commit 41f4378

Browse files
committed
docs: record sidecar abort verification
1 parent 91b3671 commit 41f4378

1 file changed

Lines changed: 16 additions & 2 deletions

File tree

devlog/132_websocket-correctness-release/10_verification.md

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ Commits:
1313
- `e27f44c fix: harden responses websocket protocol`
1414
- `2e4733d fix: preserve websocket turn cancellation hooks`
1515
- `df8c047 fix: abort websocket turns before upstream headers`
16+
- `91b3671 fix: propagate websocket aborts to sidecars`
1617

1718
Modified:
1819

@@ -41,7 +42,8 @@ Modified:
4142
headers, including Codex rate-limit header families; inbound WS data stores only forwarded
4243
allowlist headers.
4344
- Cancellation: socket close still cancels upstream, and same-socket replacement turns cancel the
44-
previous in-flight reader/fetch before upstream headers arrive and suppress stale frames.
45+
previous in-flight reader/fetch before upstream headers arrive, including vision/web-search
46+
sidecar fetches, and suppress stale frames.
4547
- Framing/backpressure: CRLF, multiline data, split chunks, unterminated final event, dropped send,
4648
`-1` backpressure, and bounded sniff replay are covered by tests.
4749
- Advertisement: absent `websockets` is now false; only explicit `websockets: true` advertises
@@ -55,8 +57,12 @@ Modified:
5557
- 19 pass, 0 fail, 39 assertions.
5658
- `bun test tests/passthrough-abort.test.ts`
5759
- 4 pass, 0 fail, 8 assertions.
60+
- `bun test tests/sidecar-abort.test.ts`
61+
- 2 pass, 0 fail, 6 assertions.
62+
- `bun test tests/sidecar-abort.test.ts tests/ws-endpoint.test.ts tests/passthrough-abort.test.ts`
63+
- 25 pass, 0 fail, 53 assertions.
5864
- `bun test tests`
59-
- 81 pass, 0 fail, 264 assertions.
65+
- 83 pass, 0 fail, 270 assertions.
6066
- `bun x tsc --noEmit`
6167
- passed with exit 0.
6268

@@ -119,3 +125,11 @@ Regression coverage:
119125
controller before response headers arrive.
120126
- `tests/ws-endpoint.test.ts` asserts stale successful response bodies are cancelled before pumping
121127
and Codex rate-limit headers survive WebSocket error sanitization.
128+
129+
The second read-only Phase 132 release review found a remaining sidecar cancellation gap. Fix:
130+
131+
- `options.abortSignal` now threads through `describeImagesInPlace`, `describeImage`,
132+
`runWithWebSearch`, and `runWebSearch`.
133+
- `src/abort.ts` composes the per-turn abort signal with each sidecar timeout signal.
134+
- `tests/sidecar-abort.test.ts` asserts both web-search and vision sidecar fetches observe the
135+
WebSocket turn abort signal.

0 commit comments

Comments
 (0)