Skip to content

Commit 429fa3b

Browse files
committed
ci: note that runner groups are unavailable on a user-owned repo
The corrected comment listed runner-group restrictions among the controls that hold the boundary from outside the workflow file. They would, but `gh api repos/lidge-jun/opencodex/actions/runners/groups` returns 404 and the owner type is User: runner groups are an organisation feature. A maintainer reading that list could reach for a lever that does not exist here, so name the constraint and say plainly that the fork-PR approval policy is the only one of the three actually available.
1 parent 7279a6f commit 429fa3b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,10 @@ jobs:
5959
#
6060
# What actually keeps untrusted code off a self-hosted runner lives OUTSIDE
6161
# this file, where a PR cannot reach it: the fork-PR approval policy
62-
# (`all_external_contributors`), runner-group restrictions, and the judgement
63-
# of whoever clicks approve. GitHub's own guidance is to avoid self-hosted
62+
# (`all_external_contributors`) and the judgement of whoever clicks approve.
63+
# Runner groups would be the other lever, but they are an organisation
64+
# feature and this repository is user-owned, so the approval policy is the
65+
# only one available here. GitHub's own guidance is to avoid self-hosted
6466
# runners on public repositories for this reason.
6567
#
6668
# So read the routing below as a COST control that keeps honest pull requests

0 commit comments

Comments
 (0)