fix(gui): i18n combo effort-none option + avoid ref access during render in codex-auth modal (lint)

Author: lidge-jun

gui/src/components/AddCodexAccountModal.tsx

@@ -18,6 +18,7 @@ export default function AddCodexAccountModal({
   const [copied, setCopied] = useState(false);
   const [manualCode, setManualCode] = useState("");
   const [manualCodeBusy, setManualCodeBusy] = useState(false);
+  const [flowId, setFlowId] = useState<string | null>(null);
 
   const aliveRef = useRef(true);
   const pollRef = useRef<ReturnType<typeof setInterval> | null>(null);
@@ -52,6 +53,7 @@ export default function AddCodexAccountModal({
     clearManualCode();
     const flowId = flowRef.current;
     flowRef.current = null;
+    setFlowId(null);
     setAuthUrl("");
     stopPolling();
     loginAbortRef.current?.abort();
@@ -71,6 +73,7 @@ export default function AddCodexAccountModal({
     loginAbortRef.current = null;
     const flowId = flowRef.current;
     flowRef.current = null;
+    setFlowId(null);
     if (pollRef.current) { clearInterval(pollRef.current); pollRef.current = null; }
     if (timeoutRef.current) { clearTimeout(timeoutRef.current); timeoutRef.current = null; }
     // Cancel in-flight OAuth so a remounted modal cannot race a stale chatgpt scratch slot.
@@ -91,6 +94,7 @@ export default function AddCodexAccountModal({
   const startOAuth = useCallback(async (requestedId?: string) => {
     clearManualCode();
     flowRef.current = null;
+    setFlowId(null);
     const controller = new AbortController();
     loginAbortRef.current?.abort();
     loginAbortRef.current = controller;
@@ -115,6 +119,7 @@ export default function AddCodexAccountModal({
       }
       if (data.url) {
         flowRef.current = data.flowId ?? null;
+        setFlowId(data.flowId ?? null);
         setAuthUrl(data.url);
         setStep("oauth-waiting");
         stopPolling();
@@ -130,13 +135,15 @@ export default function AddCodexAccountModal({
               stopPolling();
               clearManualCode();
               flowRef.current = null;
+              setFlowId(null);
               if (!aliveRef.current) return;
               onAddedRef.current();
               onCloseRef.current();
             } else if (st.status === "error" || st.status === "expired") {
               stopPolling();
               clearManualCode();
               flowRef.current = null;
+              setFlowId(null);
               if (aliveRef.current) {
                 if (!reauthAccountId) setStep("pick");
                 setError(st.error ?? "Login failed");
@@ -308,7 +315,7 @@ export default function AddCodexAccountModal({
                 <button
                   className="btn btn-ghost"
                   type="button"
-                  disabled={manualCodeBusy || !manualCode.trim() || !flowRef.current}
+                  disabled={manualCodeBusy || !manualCode.trim() || !flowId}
                   onClick={() => void submitManualCode()}
                 >
                   {manualCodeBusy ? t("prov.pasteSubmitting") : t("prov.pasteSubmit")}

gui/src/components/ComboWorkspace.tsx

@@ -140,7 +140,7 @@ function EffortSelect({
       aria-label={t("cws.field.defaultEffort")}
       onChange={(e) => onChange(e.target.value === "" ? null : e.target.value as ComboEffort)}
     >
-      <option value="">None (target default)</option>
+      <option value="">{t("cws.field.defaultEffortNone")}</option>
       {COMBO_EFFORTS.map((effort) => (
         <option key={effort} value={effort}>{effort}</option>
       ))}

gui/src/i18n/de.ts

@@ -923,6 +923,7 @@ export const de = {
   "cws.field.stickyLimit": "Sticky-Erfolge vor Rotation",
   "cws.field.stickyLimitHint": "Das gewählte Ziel für so viele erfolgreiche Anfragen behalten, bevor die gewichtete Auswahl weiterschaltet.",
   "cws.field.defaultEffort": "Standard-Reasoning",
+  "cws.field.defaultEffortNone": "Keine (Ziel-Standard)",
   "cws.field.defaultEffortHint": "Nur verwendet, wenn der Client keinen Reasoning-Aufwand sendet. Der Client-Wert hat Vorrang; jedes Ziel wendet seine eigene Fähigkeitsbehandlung an.",
   "cws.targets": "Ziele",
   "cws.targets.failoverHint": "Reihenfolge zählt — das erste ist primär.",

gui/src/i18n/en.ts

@@ -944,6 +944,7 @@ export const en = {
   "cws.field.stickyLimit": "Sticky successes before rotate",
   "cws.field.stickyLimitHint": "Retain the selected target for this many successful requests before the weighted selector advances.",
   "cws.field.defaultEffort": "Default reasoning",
+  "cws.field.defaultEffortNone": "None (target default)",
   "cws.field.defaultEffortHint": "Used only when the client omits reasoning effort. Client effort wins, and each target applies its own capability handling.",
   "cws.targets": "Targets",
   "cws.targets.failoverHint": "Order matters — first is primary.",

gui/src/i18n/ko.ts

@@ -943,6 +943,7 @@ export const ko: Record<TKey, string> = {
   "cws.field.stickyLimit": "회전 전 sticky 성공 횟수",
   "cws.field.stickyLimitHint": "가중 선택기가 다음 대상으로 진행하기 전에 선택된 대상을 이 성공 요청 횟수만큼 유지합니다.",
   "cws.field.defaultEffort": "기본 추론 수준",
+  "cws.field.defaultEffortNone": "없음 (대상 기본값)",
   "cws.field.defaultEffortHint": "클라이언트가 추론 수준을 생략한 경우에만 사용합니다. 클라이언트 값이 우선하며 각 대상이 자체 기능에 맞게 처리합니다.",
   "cws.targets": "대상",
   "cws.targets.failoverHint": "순서가 중요합니다 — 첫 번째가 기본입니다.",

gui/src/i18n/ru.ts

@@ -946,6 +946,7 @@ export const ru: Record<TKey, string> = {
   "cws.field.stickyLimit": "Успешных запросов до ротации",
   "cws.field.stickyLimitHint": "Выбранная цель удерживается на указанное число успешных запросов, прежде чем взвешенный селектор перейдёт к следующей.",
   "cws.field.defaultEffort": "Рассуждения по умолчанию",
+  "cws.field.defaultEffortNone": "Нет (по умолчанию для цели)",
   "cws.field.defaultEffortHint": "Используется, только если клиент не указал уровень рассуждений. Значение клиента имеет приоритет, а каждая цель применяет собственную обработку возможностей.",
   "cws.targets": "Цели",
   "cws.targets.failoverHint": "Порядок важен — первая цель основная.",

gui/src/i18n/zh.ts

@@ -943,6 +943,7 @@ export const zh: Record<TKey, string> = {
   "cws.field.stickyLimit": "轮换前的粘性成功次数",
   "cws.field.stickyLimitHint": "加权选择器推进前，将所选目标保留这么多次成功请求。",
   "cws.field.defaultEffort": "默认推理级别",
+  "cws.field.defaultEffortNone": "无（使用目标默认）",
   "cws.field.defaultEffortHint": "仅在客户端未指定推理级别时使用。客户端值优先，每个目标会按自身能力进行处理。",
   "cws.targets": "目标",
   "cws.targets.failoverHint": "顺序很重要 — 第一个为主。",