Commit 98d2576
committed
docs(plan): the Windows red was Bun crashing, not our tests
Read the CI log to the end after pushing the stability fix: zero tests
failed. The run died on
panic(thread 2852): Internal assertion failure
oh no: Bun has crashed. This indicates a bug in Bun, not your code.
Bun v1.3.14, Windows x64, bun test --isolate. That explains the part
that never made sense: a process dying at an arbitrary point marks
whichever test was running as failed, so the blame moved tray to
sidebar to server-auth without any of them being at fault.
010 had already bucketed the #744 and #693 Windows failures as a Bun
runtime panic class. Same thing, seen from the other side.
The two fixes still stand on their own -- spawning a real gh in a route
test and building four harnesses in one test were genuine defects. They
just were not what was keeping Windows red, and saying otherwise would
be claiming a result we did not get.
Note for next time: when Windows CI is red, read the tail of the log
before the test names.1 parent b79eb71 commit 98d2576
1 file changed
Lines changed: 42 additions & 0 deletions
Lines changed: 42 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
0 commit comments