Skip to content

Commit a9d2270

Browse files
committed
docs: record web-search loop abort verification
1 parent 78ca706 commit a9d2270

1 file changed

Lines changed: 10 additions & 3 deletions

File tree

devlog/132_websocket-correctness-release/10_verification.md

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ Commits:
1414
- `2e4733d fix: preserve websocket turn cancellation hooks`
1515
- `df8c047 fix: abort websocket turns before upstream headers`
1616
- `91b3671 fix: propagate websocket aborts to sidecars`
17+
- `78ca706 fix: abort web-search loop provider fetches`
1718

1819
Modified:
1920

@@ -58,11 +59,11 @@ Modified:
5859
- `bun test tests/passthrough-abort.test.ts`
5960
- 4 pass, 0 fail, 8 assertions.
6061
- `bun test tests/sidecar-abort.test.ts`
61-
- 2 pass, 0 fail, 6 assertions.
62+
- 3 pass, 0 fail, 10 assertions.
6263
- `bun test tests/sidecar-abort.test.ts tests/ws-endpoint.test.ts tests/passthrough-abort.test.ts`
63-
- 25 pass, 0 fail, 53 assertions.
64+
- 26 pass, 0 fail, 57 assertions.
6465
- `bun test tests`
65-
- 83 pass, 0 fail, 270 assertions.
66+
- 84 pass, 0 fail, 274 assertions.
6667
- `bun x tsc --noEmit`
6768
- passed with exit 0.
6869

@@ -133,3 +134,9 @@ The second read-only Phase 132 release review found a remaining sidecar cancella
133134
- `src/abort.ts` composes the per-turn abort signal with each sidecar timeout signal.
134135
- `tests/sidecar-abort.test.ts` asserts both web-search and vision sidecar fetches observe the
135136
WebSocket turn abort signal.
137+
138+
The third read-only Phase 132 release review found one last web-search loop gap. Fix:
139+
140+
- The routed-provider fetch inside `runWithWebSearch` now receives the WebSocket turn abort signal.
141+
- `tests/sidecar-abort.test.ts` asserts the loop's routed-provider fetch receives and observes the
142+
same abort signal.

0 commit comments

Comments
 (0)