fix(providers): address SambaNova and Nebius review feedback

olddonkey · olddonkey · commit b454bbadb130 · 2026-08-03T01:49:23.000-07:00
diff --git a/docs-site/src/content/docs/ja/getting-started/quickstart.md b/docs-site/src/content/docs/ja/getting-started/quickstart.md
@@ -13,8 +13,7 @@ ocx init
 
 `ocx init` では次の手順を説明します。
 
-1. **プロバイダーを選択してください** — 71 の組み込みレジストリ プリセットのいずれか、または `custom` を選択してベースを入力します
-URLとアダプター。
+1. **プロバイダーを選択してください** — 71 個の組み込みレジストリプリセットのいずれか、または `custom` を選択してベース URL とアダプターを入力します。
 2. **API キー** — キーを貼り付けるか、`${ANTHROPIC_API_KEY}` のような環境変数を参照します。
 3. **デフォルト モデル** — キー、ローカル、カスタム プロバイダーの場合は、プリセットを受け入れるか、モデル ID を入力します。
 4. **プロキシ ポート** — デフォルトは `10100` です。
diff --git a/src/providers/free-directory.ts b/src/providers/free-directory.ts
@@ -132,7 +132,7 @@ const CONNECTABLE: Record<string, ConnectableOverride> = {
   hyperbolic: openAi("https://api.hyperbolic.xyz/v1", "https://app.hyperbolic.xyz/settings", { verification: "official" }),
   longcat: openAi("https://api.longcat.chat/openai/v1", "https://longcat.chat", { verification: "official", discovery: "static", liveModels: false, models: ["LongCat-2.0"] }),
   monsterapi: openAi("https://api.monsterapi.ai/v1", "https://monsterapi.ai", { verification: "official" }),
-  nebius: openAi("https://api.tokenfactory.nebius.com/v1", "https://tokenfactory.nebius.com", { supportLevel: "supported", verification: "official", documentationUrl: "https://docs.tokenfactory.nebius.com/quickstart", lastVerified: "2026-08-01" }),
+  nebius: openAi("https://api.tokenfactory.nebius.com/v1", "https://tokenfactory.nebius.com", { supportLevel: "supported", verification: "official", documentationUrl: "https://docs.tokenfactory.nebius.com/quickstart", modelsUrl: "https://api.tokenfactory.nebius.com/v1/models?verbose=true", lastVerified: "2026-08-01" }),
   novita: openAi("https://api.novita.ai/openai/v1", "https://novita.ai/settings/key-management", { supportLevel: "supported", verification: "official", modelsUrl: "https://api.novita.ai/openai/v1/models" }),
   nscale: openAi("https://inference.api.nscale.com/v1", "https://console.nscale.com", { verification: "official" }),
   nvidia: openAi("https://integrate.api.nvidia.com/v1", "https://build.nvidia.com", { supportLevel: "supported", verification: "official", documentationUrl: "https://docs.api.nvidia.com/nim/reference/llm-apis" }),
diff --git a/src/providers/model-discovery.ts b/src/providers/model-discovery.ts
@@ -2,6 +2,7 @@ import type { OcxProviderConfig } from "../types";
 import {
   getProviderRegistryEntry,
   providerMatchesRegistryTransport,
+  registryEntryForProviderDestination,
   type ProviderModelDiscoveryFilter,
   type ProviderModelDiscoveryPredicate,
   type ProviderModelDiscoveryScalar,
@@ -124,9 +125,14 @@ export function resolveProviderModelDiscovery(
   providerName: string,
   provider: Pick<OcxProviderConfig, "baseUrl" | "adapter"> & Partial<Pick<OcxProviderConfig, "authMode">>,
 ): ResolvedProviderModelDiscovery {
-  const entry = providerMatchesRegistryTransport(providerName, provider)
-    ? getProviderRegistryEntry(providerName)
-    : undefined;
+  // The dashboard permits a canonical preset to be saved under a different name. Recover its
+  // registry-owned discovery policy by transport in that case. The destination helper is limited
+  // to exact fixed-key baseUrl + adapter matches, so custom endpoints, OAuth rows, templates, and
+  // overridable destinations cannot acquire another provider's discovery URL or filter.
+  const namedEntry = getProviderRegistryEntry(providerName);
+  const entry = namedEntry
+    ? (providerMatchesRegistryTransport(providerName, provider) ? namedEntry : undefined)
+    : registryEntryForProviderDestination(provider);
   const spec = entry?.modelDiscovery;
   return {
     ...(spec ? { spec } : {}),
diff --git a/tests/provider-model-discovery-contract.test.ts b/tests/provider-model-discovery-contract.test.ts
@@ -13,7 +13,11 @@ import {
   readBoundedDiscoveryJson,
   resolveProviderModelDiscovery,
 } from "../src/providers/model-discovery";
-import { PROVIDER_REGISTRY, type ProviderModelDiscoverySpec } from "../src/providers/registry";
+import {
+  PROVIDER_REGISTRY,
+  registryEntryForProviderDestination,
+  type ProviderModelDiscoverySpec,
+} from "../src/providers/registry";
 import { routeModel } from "../src/router";
 import type { OcxConfig, OcxProviderConfig } from "../src/types";
 import { withStubbedProviderFetch } from "./helpers/catalog-provider-fetch";
@@ -104,6 +108,18 @@ describe("registry-owned provider model discovery", () => {
     }
   });
 
+  test("keeps discovery-bearing fixed key destinations unambiguous for renamed presets", () => {
+    for (const entry of PROVIDER_REGISTRY) {
+      if (!entry.modelDiscovery || entry.authKind !== "key") continue;
+      if (entry.allowBaseUrlOverride || /\{[^}]*\}/.test(entry.baseUrl)) continue;
+      expect(registryEntryForProviderDestination({
+        adapter: entry.adapter,
+        baseUrl: entry.baseUrl,
+        authMode: "key",
+      })?.id).toBe(entry.id);
+    }
+  });
+
   test("derives an alternate path and query only for the canonical destination", async () => {
     await withTogetherDiscovery({
       path: "catalog",
@@ -112,6 +128,14 @@ describe("registry-owned provider model discovery", () => {
       const canonical = buildModelsRequest(togetherConfig().providers.together!, "secret", "together");
       expect(canonical.url).toBe("https://api.together.xyz/v1/catalog?capability=chat&limit=100");
 
+      const renamedCanonical = buildModelsRequest(
+        togetherConfig().providers.together!,
+        "secret",
+        "together-team",
+      );
+      expect(renamedCanonical.url)
+        .toBe("https://api.together.xyz/v1/catalog?capability=chat&limit=100");
+
       const collidingCustom: OcxProviderConfig = {
         adapter: "openai-chat",
         baseUrl: "https://custom.example/v9",
diff --git a/tests/sambanova-nebius-provider.test.ts b/tests/sambanova-nebius-provider.test.ts
@@ -12,6 +12,8 @@ import {
   deriveProviderPresets,
   providerConfigSeed,
 } from "../src/providers/derive";
+import { FREE_PROVIDER_DIRECTORY } from "../src/providers/free-directory";
+import { resolveProviderModelDiscovery } from "../src/providers/model-discovery";
 import { PROVIDER_REGISTRY, type ProviderRegistryEntry } from "../src/providers/registry";
 import { routedSlug } from "../src/providers/slug-codec";
 import { routeModel } from "../src/router";
@@ -51,6 +53,7 @@ afterEach(() => {
   globalThis.fetch = originalFetch;
   clearModelCache("sambanova");
   clearModelCache("nebius");
+  clearModelCache("nebius-team");
 });
 
 function registryEntry(id: ProviderId): ProviderRegistryEntry {
@@ -90,7 +93,9 @@ describe("SambaNova and Nebius providers", () => {
       dashboardUrl: PROVIDERS.sambanova.dashboardUrl,
       liveModels: true,
       preserveCustomDestination: true,
+      apiKeyValidation: "unknown",
       parallelToolCalls: false,
+      reasoningEfforts: [],
       modelDiscovery: {
         path: "models",
         maxResponseBytes: 131_072,
@@ -109,6 +114,7 @@ describe("SambaNova and Nebius providers", () => {
       liveModels: true,
       preserveCustomDestination: true,
       parallelToolCalls: false,
+      reasoningEfforts: [],
       modelDiscovery: {
         path: "models",
         query: { verbose: "true" },
@@ -120,6 +126,9 @@ describe("SambaNova and Nebius providers", () => {
       },
     });
     expect(registryEntry("nebius").note).toContain("embedding and image-generation rows");
+    expect(FREE_PROVIDER_DIRECTORY.find(row => row.id === "nebius")).toMatchObject({
+      modelsUrl: PROVIDERS.nebius.modelsUrl,
+    });
   });
 
   test("derives CLI and dashboard presets without persisting registry trust policy", () => {
@@ -133,6 +142,7 @@ describe("SambaNova and Nebius providers", () => {
         baseUrl: provider.baseUrl,
         dashboardUrl: provider.dashboardUrl,
         liveModels: true,
+        ...(id === "sambanova" ? { apiKeyValidation: "unknown" } : {}),
       });
       expect(buildInitProviders().find(row => row.id === id)).toMatchObject({
         kind: "key",
@@ -151,34 +161,52 @@ describe("SambaNova and Nebius providers", () => {
         authMode: "key",
         liveModels: true,
         parallelToolCalls: false,
+        reasoningEfforts: [],
       });
+      expect(seed).not.toHaveProperty("apiKeyValidation");
       expect(seed).not.toHaveProperty("modelDiscovery");
       expect(seed).not.toHaveProperty("preserveCustomDestination");
       expect(KEY_LOGIN_PROVIDERS[id]).not.toHaveProperty("modelDiscovery");
       expect(KEY_LOGIN_PROVIDERS[id]).not.toHaveProperty("preserveCustomDestination");
     }
   });
 
-  test("lists and validates models through each registry-owned endpoint", async () => {
+  test("builds each registry-owned models request and validates the authenticated Nebius catalog", async () => {
     for (const id of ["sambanova", "nebius"] as const) {
       const provider = PROVIDERS[id];
       expect(buildModelsRequest(providerConfig(id).providers[id]!, provider.key, id)).toEqual({
         url: provider.modelsUrl,
         headers: { Authorization: `Bearer ${provider.key}` },
       });
+    }
 
-      globalThis.fetch = (async (input, init) => {
-        expect(String(input)).toBe(provider.modelsUrl);
-        expect(new Headers(init?.headers).get("authorization")).toBe(`Bearer ${provider.key}`);
-        expect(init?.redirect).toBe("error");
-        return new Response(provider.fixture, {
-          status: 200,
-          headers: { "content-type": "application/json" },
-        });
-      }) as typeof fetch;
+    const provider = PROVIDERS.nebius;
+    globalThis.fetch = (async (input, init) => {
+      expect(String(input)).toBe(provider.modelsUrl);
+      expect(new Headers(init?.headers).get("authorization")).toBe(`Bearer ${provider.key}`);
+      expect(init?.redirect).toBe("error");
+      return new Response(provider.fixture, {
+        status: 200,
+        headers: { "content-type": "application/json" },
+      });
+    }) as typeof fetch;
 
-      expect(await validateApiKey(id, KEY_LOGIN_PROVIDERS[id]!, provider.key)).toBe(true);
-    }
+    expect(await validateApiKey("nebius", KEY_LOGIN_PROVIDERS.nebius!, provider.key)).toBe(true);
+  });
+
+  test("does not treat SambaNova's public model catalog as proof that a key is valid", async () => {
+    let fetchCalled = false;
+    globalThis.fetch = (async () => {
+      fetchCalled = true;
+      return new Response(SAMBANOVA_FIXTURE, { status: 200 });
+    }) as typeof fetch;
+
+    expect(await validateApiKey(
+      "sambanova",
+      KEY_LOGIN_PROVIDERS.sambanova!,
+      PROVIDERS.sambanova.key,
+    )).toBe("unknown");
+    expect(fetchCalled).toBe(false);
   });
 
   test("filters Nebius mixed rows and preserves model metadata and native ids", async () => {
@@ -220,6 +248,7 @@ describe("SambaNova and Nebius providers", () => {
     expect(sambanovaModels[1]).toMatchObject({
       owned_by: "sambanova",
       contextWindow: 131_072,
+      reasoningEfforts: [],
     });
     expect(nebiusModels.map(row => row.id)).toEqual([
       "meta-llama/Meta-Llama-3.1-8B-Instruct-fast",
@@ -230,6 +259,7 @@ describe("SambaNova and Nebius providers", () => {
       contextWindow: 131_072,
       inputModalities: ["text"],
       capabilities: ["function-calling", "json-mode"],
+      reasoningEfforts: [],
     });
     expect(nebiusModels[1]).toMatchObject({
       contextWindow: 262_144,
@@ -246,6 +276,33 @@ describe("SambaNova and Nebius providers", () => {
     }
   });
 
+  test("keeps Nebius query and text-output filtering when the preset is renamed", async () => {
+    const provider = PROVIDERS.nebius;
+    globalThis.fetch = (async (input, init) => {
+      expect(String(input)).toBe(provider.modelsUrl);
+      expect(new Headers(init?.headers).get("authorization")).toBe(`Bearer ${provider.key}`);
+      expect(init?.redirect).toBe("manual");
+      return new Response(provider.fixture, {
+        status: 200,
+        headers: { "content-type": "application/json" },
+      });
+    }) as typeof fetch;
+
+    const renamed = "nebius-team";
+    const config = withStubbedProviderFetch({
+      port: 10100,
+      defaultProvider: renamed,
+      providers: {
+        [renamed]: providerConfig("nebius").providers.nebius!,
+      },
+    } satisfies OcxConfig);
+    const models = await gatherRoutedModels(config);
+    expect(models.filter(row => row.provider === renamed).map(row => row.id)).toEqual([
+      "meta-llama/Meta-Llama-3.1-8B-Instruct-fast",
+      "Qwen/Qwen3-VL-235B-A22B-Instruct",
+    ]);
+  });
+
   test("routes tool requests to the fixed hosts without claiming parallel tool calls", () => {
     const cases = [
       ["sambanova", "Meta-Llama-3.3-70B-Instruct"],
@@ -265,14 +322,15 @@ describe("SambaNova and Nebius providers", () => {
           }],
         },
         stream: true,
-        options: {},
+        options: { reasoning: "high" },
       });
       const body = JSON.parse(String(request.body)) as Record<string, unknown>;
 
       expect(request.url).toBe(`${PROVIDERS[providerId].baseUrl}/chat/completions`);
       expect(request.headers.Authorization).toBe(`Bearer ${PROVIDERS[providerId].key}`);
       expect(body.model).toBe(modelId);
       expect(body.parallel_tool_calls).toBe(false);
+      expect(body).not.toHaveProperty("reasoning_effort");
     }
   });
 
@@ -300,5 +358,14 @@ describe("SambaNova and Nebius providers", () => {
         authMode: "key",
       });
     }
+
+    const crossPreset = providerConfig("sambanova", {
+      baseUrl: PROVIDERS.nebius.baseUrl,
+    }).providers.sambanova!;
+    expect(resolveProviderModelDiscovery("sambanova", crossPreset).spec).toBeUndefined();
+    expect(buildModelsRequest(crossPreset, "custom-key", "sambanova")).toEqual({
+      url: `${PROVIDERS.nebius.baseUrl}/models`,
+      headers: { Authorization: "Bearer custom-key" },
+    });
   });
 });
