fix(ci): strip WRONG BRANCH prefix when base is corrected

Author: Wibias

.github/scripts/enforce-pr-target.test.cjs

@@ -60,4 +60,16 @@ describe("enforce-pr-target workflow", () => {
     assert.match(workflow, /pr-quality\.cjs/);
     assert.match(workflow, /collectPrQualityFailures/);
   });
+
+  it("strips stale WRONG BRANCH prefix on failure when base is corrected", () => {
+    const failureBlock = workflow.match(
+      /if \(failures\.length > 0\) \{([\s\S]*?)core\.setFailed\(/,
+    );
+    assert.ok(failureBlock, "workflow must have a failure path");
+    const failurePath = failureBlock[1];
+    assert.match(failurePath, /shouldStripTitlePrefix/);
+    assert.match(failurePath, /!hasWrongBase/);
+    assert.match(failurePath, /titlePrefixedByBot = false/);
+    assert.match(failurePath, /pr\.title\.slice\(TITLE_PREFIX\.length\)/);
+  });
 });

.github/workflows/enforce-pr-target.yml

@@ -332,8 +332,15 @@ jobs:
                 failure => failure.code === "bad_description"
               );
 
+              const shouldStripTitlePrefix =
+                !hasWrongBase &&
+                state.titlePrefixedByBot &&
+                pr.title.startsWith(TITLE_PREFIX);
+
               if (willPrefixTitle) {
                 state.titlePrefixedByBot = true;
+              } else if (shouldStripTitlePrefix) {
+                state.titlePrefixedByBot = false;
               }
 
               let draftConversionFailed = false;
@@ -357,6 +364,13 @@ jobs:
                   pull_number,
                   title: `${TITLE_PREFIX}${pr.title}`
                 });
+              } else if (shouldStripTitlePrefix) {
+                await github.rest.pulls.update({
+                  owner,
+                  repo,
+                  pull_number,
+                  title: pr.title.slice(TITLE_PREFIX.length)
+                });
               }
 
               if (!pr.draft) {