docs(codex): clarify pool routing and account continuity - #862
Conversation
github-actions
Bot
added
the
documentation
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThe pull request aligns Codex account-pool behavior across CLI messages, reference documentation, GUI controls, translations, and tests. It documents affinity reset, unbound-task assignment, strategy-specific switching, recovery, conversation replay, and provider prompt-cache behavior. ChangesAccount pool routing semantics
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a444761f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs-site/src/content/docs/reference/cli.md`:
- Around line 370-374: Update the App login documentation so failure-time
account rotation is clearly independent of usage-based switching and cannot be
disabled by auto-switch off: in docs-site/src/content/docs/reference/cli.md
lines 370-374, define the Pool-versus-Direct behavior, process-local affinity
reset, 401/403 reauthentication, 429/retry-after cooldowns,
threshold-independent recovery, and prompt-cache continuity, then use it as the
translation source. Apply the equivalent semantics in
docs-site/src/content/docs/ja/reference/cli.md lines 271-275,
docs-site/src/content/docs/ko/reference/cli.md lines 312-316,
docs-site/src/content/docs/ru/reference/cli.md lines 301-306, and
docs-site/src/content/docs/zh-cn/reference/cli.md lines 262-265.
In `@gui/src/components/CodexAccountPool.tsx`:
- Line 55: Keep poolStrategy unresolved until CodexPoolStrategySetting finishes
loading instead of initializing it to DEFAULT_ACCOUNT_POOL_STRATEGY. Update the
rendering around the strategy explanation and threshold control, including
CodexAutoSwitchSetting, so quota-specific UI is deferred or disabled while
unresolved and only becomes interactive after the persisted strategy succeeds;
add a regression test covering a delayed round-robin or fill-first response.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f2b4ab40-c403-4b8e-8c65-4b2a4f84475c
📒 Files selected for processing (24)
docs-site/src/content/docs/ja/reference/cli.mddocs-site/src/content/docs/ja/reference/configuration.mddocs-site/src/content/docs/ko/reference/cli.mddocs-site/src/content/docs/ko/reference/configuration.mddocs-site/src/content/docs/reference/cli.mddocs-site/src/content/docs/reference/configuration.mddocs-site/src/content/docs/ru/reference/cli.mddocs-site/src/content/docs/ru/reference/configuration.mddocs-site/src/content/docs/zh-cn/reference/cli.mddocs-site/src/content/docs/zh-cn/reference/configuration.mdgui/src/components/AccountPoolStrategyControls.tsxgui/src/components/CodexAccountPool.tsxgui/src/components/CodexAutoSwitchSetting.tsxgui/src/components/CodexPoolStrategySetting.tsxgui/src/i18n/de.tsgui/src/i18n/en.tsgui/src/i18n/ja.tsgui/src/i18n/ko.tsgui/src/i18n/ru.tsgui/src/i18n/zh.tsgui/tests/codex-account-auto-switch.test.tsxsrc/cli/account.tssrc/cli/help.tstests/cli-account.test.ts
|
Follow-up review fixes are in
Local validation: 63 CLI tests, all 468 GUI tests on Bun 1.4.0-canary.1, 43 focused GUI tests on bundled Bun 1.3.14, GUI ESLint, i18n lint, production GUI build, root typecheck/privacy checks, and a successful frozen docs production build. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs-site/src/content/docs/ja/reference/configuration.md`:
- Around line 99-100: In the Japanese configuration documentation paragraph
describing the quota assignment and proactive switching strategy, remove the
duplicated threshold clause spanning the line break and fix the surrounding
punctuation so the sentence contains only one autoSwitchThreshold condition
before continuing to the round-robin description.
In `@docs-site/src/content/docs/reference/cli.md`:
- Around line 370-377: Document the complete failure-time routing contract
across all listed CLI and configuration locale sections: in each CLI file, state
that 401/403 clears affinity and requires reauthentication, while 429 honors
Retry-After, starts cooldown, clears affinity, and may rotate to another
eligible Pool account; in each configuration file, add those explicit
transitions while retaining the existing one-retry 429/402 rule. Keep
autoSwitchThreshold: 0 limited to usage-based proactive switching, with failure
recovery still active. Update
docs-site/src/content/docs/reference/cli.md:370-377,
docs-site/src/content/docs/ja/reference/cli.md:271-272,
docs-site/src/content/docs/ko/reference/cli.md:312-313,
docs-site/src/content/docs/ru/reference/cli.md:301-302,
docs-site/src/content/docs/zh-cn/reference/cli.md:262-262,
docs-site/src/content/docs/reference/configuration.md:143-151,
docs-site/src/content/docs/ja/reference/configuration.md:88-97,
docs-site/src/content/docs/ko/reference/configuration.md:90-97,
docs-site/src/content/docs/ru/reference/configuration.md:96-104, and
docs-site/src/content/docs/zh-cn/reference/configuration.md:85-94, translating
the additions appropriately for each locale.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 502eca5f-90b4-4a81-b914-408093844e43
📒 Files selected for processing (13)
docs-site/src/content/docs/ja/reference/cli.mddocs-site/src/content/docs/ja/reference/configuration.mddocs-site/src/content/docs/ko/reference/cli.mddocs-site/src/content/docs/ko/reference/configuration.mddocs-site/src/content/docs/reference/cli.mddocs-site/src/content/docs/reference/configuration.mddocs-site/src/content/docs/ru/reference/cli.mddocs-site/src/content/docs/ru/reference/configuration.mddocs-site/src/content/docs/zh-cn/reference/cli.mddocs-site/src/content/docs/zh-cn/reference/configuration.mdgui/src/components/CodexAccountPool.tsxgui/tests/account-pool-strategy.test.tsxgui/tests/codex-auto-switch-controller.test.tsx
1 participant
Fixes #806
Summary
Scope
This is a semantic copy and documentation correction only. It does not change pool routing, affinity, quota, retry, or failover behavior, and it does not redesign the existing controls.
Validation
The change follows the maintainer direction in #806: English-first semantics, equivalent maintained locales, strategy-specific threshold copy, an explicit unbound-task definition, separate failure recovery, and shared continuity/cache guidance.
Summary by CodeRabbit