Skip to content

fix: release Windows ACL temp-path memos - #840

Draft
Ingwannu wants to merge 1 commit into
devfrom
agent/fix-windows-acl-memo-leak
Draft

fix: release Windows ACL temp-path memos#840
Ingwannu wants to merge 1 commit into
devfrom
agent/fix-windows-acl-memo-leak

Conversation

@Ingwannu

@Ingwannu Ingwannu commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • release successful and timed-out Windows ACL memos once an ephemeral file is proven absent
  • key atomic-write timeouts by the stable destination so unique temp names cannot accumulate
  • cover config/response state, OpenAI tier backups, management tokens, and tray replacements
  • retain memo state when a hardened residual temp remains on disk

Part of #820. This intentionally extracts the confirmed Windows leak into a focused change instead of coupling it to #829.

Verification

  • bun run typecheck
  • bun run privacy:scan
  • bun test tests/windows-secret-acl.test.ts tests/config.test.ts tests/server-management-auth.test.ts tests/windows-tray.test.ts (167 pass)
  • full suite: 6427 pass / 6 skip; 5 unrelated GUI test import errors because this checkout lacks the GUI React dependencies (react, react/jsx-dev-runtime)

Compatibility

Stable destination/directory memo behavior and fail-closed ACL policy are unchanged. Only one-shot temp path entries are released after rename/unlink or proven ENOENT.

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ba90a6fd-d1a1-4dda-8456-3b3d7976d55f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant