Add view prefix argument#83
Open
sunahsuh wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This last change may or may not be useful outside of my company's usage but we ended up in a scenario where we started with default Looker-generated views, which prefixed the schema to view names and files, built a number of explores and dashboards on top of them, and then decided to move to generated views + refinements. We wanted to match the new dbt2looker generated view names and files with the previously existing views for simplicity and to keep us from having to edit all the explores we'd already created, so I made this change in our fork. Totally understand if it doesn't seem useful enough generally to merge back upstream but I thought it was worth submitting a PR anyway.