Improve column-didn't-generate error message#95
Open
jwmanahan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code change will change the list of identical "Column type TIMESTAMP_LTZ is not supported for conversion from snowflake to looker. No dimension will be created." to start with the column names that aren't being converted.
This is useful to me and my peers because it tells us which columns need to be manually written and described in the LookML file. It continues to allow
map_adapter_type_to_looker()to work as it currently does in case there is no column name (not sure this matters though!).I've tested this by running the current prod
dbt2lookercommand against a file in my company's codebase, then running the modifieddbt2looker. More testing in the reviewer's environment wouldn't hurt.This would be even better if model name were passed to the
map_adapter_type_to_looker()function too to allow for the even clearer column name pattern ofmodel_name.column_name