fix(protocol): drop all removable timers in construct_set_timers#535
Draft
bluetoothbot wants to merge 1 commit into
Draft
fix(protocol): drop all removable timers in construct_set_timers#535bluetoothbot wants to merge 1 commit into
bluetoothbot wants to merge 1 commit into
Conversation
construct_set_timers called list.remove() while iterating over the same list. Each removal shifts subsequent elements left, so the iterator skips the element after a removed one. Adjacent inactive/expired timers (and an expired timer following any removed timer) could survive into the outgoing message, sending stale timers to the device. Set length on every timer first, then filter the list in place with a comprehension.
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix
construct_set_timersdropping only some inactive/expired timers because it mutated the list while iterating it.Why
The cleanup loop called
timer_list.remove(t)duringfor t in timer_list. Each removal shifts later elements left, so the iterator skips the element right after a removed one. Adjacent removable timers — or an active-but-expired timer following any removed timer — survived into the outgoing0x21message, sending stale timers to the device.How
Set
lengthon every timer first, then filter the list in place with a comprehension (timer_list[:] = [...]). Keeps the existing in-place mutation contract callers rely on, and preserves the later truncate/pad logic.Testing
test_construct_set_timers_drops_all_removable_timers: two adjacent active-but-expired timers must serialize identically to an empty list (six inactive padding slots). Fails on the old code, passes now.Quality Report
Changes: 2 files changed, 27 insertions(+), 2 deletions(-)
Code scan: clean
Tests: failed (FAILED)
Branch hygiene: clean
Generated by Kōan