Address PR review feedback

- Add #[cfg(test)] to RefUnwindSafe impl (matches VssStore)
- Take connection_string as String instead of &str
- Bump actions/checkout to v6 in postgres CI workflow

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: benthecarman

.github/workflows/postgres-integration.yml

@@ -1,6 +1,6 @@
 name: CI Checks - PostgreSQL Integration Tests
 
-on: [push, pull_request]
+on: [ push, pull_request ]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -27,7 +27,7 @@ jobs:
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v6
       - name: Install Rust stable toolchain
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable

src/builder.rs

@@ -639,7 +639,7 @@ impl NodeBuilder {
 	/// [PostgreSQL]: https://www.postgresql.org
 	#[cfg(feature = "postgres")]
 	pub fn build_with_postgres_store(
-		&self, node_entropy: NodeEntropy, connection_string: &str, kv_table_name: Option<String>,
+		&self, node_entropy: NodeEntropy, connection_string: String, kv_table_name: Option<String>,
 	) -> Result<Node, BuildError> {
 		let kv_store =
 			crate::io::postgres_store::PostgresStore::new(connection_string, kv_table_name)
@@ -1117,7 +1117,7 @@ impl ArcedNodeBuilder {
 		self.inner
 			.read()
 			.unwrap()
-			.build_with_postgres_store(*node_entropy, &connection_string, kv_table_name)
+			.build_with_postgres_store(*node_entropy, connection_string, kv_table_name)
 			.map(Arc::new)
 	}
 

src/io/postgres_store/mod.rs

@@ -53,6 +53,7 @@ pub struct PostgresStore {
 // RefUnwindSafe. std::sync::Mutex (used by SqliteStore) doesn't have this issue because
 // it poisons on panic. This impl is needed for do_read_write_remove_list_persist which
 // requires K: KVStoreSync + RefUnwindSafe.
+#[cfg(test)]
 impl std::panic::RefUnwindSafe for PostgresStore {}
 
 impl PostgresStore {
@@ -61,7 +62,7 @@ impl PostgresStore {
 	/// Connects to the PostgreSQL database at the given `connection_string`.
 	///
 	/// The given `kv_table_name` will be used or default to [`DEFAULT_KV_TABLE_NAME`].
-	pub fn new(connection_string: &str, kv_table_name: Option<String>) -> io::Result<Self> {
+	pub fn new(connection_string: String, kv_table_name: Option<String>) -> io::Result<Self> {
 		let internal_runtime = tokio::runtime::Builder::new_multi_thread()
 			.enable_all()
 			.thread_name_fn(|| {
@@ -74,7 +75,6 @@ impl PostgresStore {
 			.build()
 			.unwrap();
 
-		let connection_string = connection_string.to_string();
 		let inner = tokio::task::block_in_place(|| {
 			internal_runtime.block_on(async {
 				PostgresStoreInner::new(&connection_string, kv_table_name).await
@@ -686,7 +686,7 @@ mod tests {
 	}
 
 	fn create_test_store(table_name: &str) -> PostgresStore {
-		PostgresStore::new(&test_connection_string(), Some(table_name.to_string())).unwrap()
+		PostgresStore::new(test_connection_string(), Some(table_name.to_string())).unwrap()
 	}
 
 	fn cleanup_store(store: &PostgresStore) {

tests/integration_tests_postgres.rs

@@ -29,7 +29,7 @@ async fn channel_full_cycle_with_postgres_store() {
 	let node_a = builder_a
 		.build_with_postgres_store(
 			config_a.node_entropy,
-			&test_connection_string(),
+			test_connection_string(),
 			Some("channel_cycle_a".to_string()),
 		)
 		.unwrap();
@@ -42,7 +42,7 @@ async fn channel_full_cycle_with_postgres_store() {
 	let node_b = builder_b
 		.build_with_postgres_store(
 			config_b.node_entropy,
-			&test_connection_string(),
+			test_connection_string(),
 			Some("channel_cycle_b".to_string()),
 		)
 		.unwrap();
@@ -80,7 +80,7 @@ async fn postgres_node_restart() {
 		let node = builder
 			.build_with_postgres_store(
 				node_entropy,
-				&connection_string,
+				connection_string.clone(),
 				Some("restart_test".to_string()),
 			)
 			.unwrap();
@@ -113,7 +113,7 @@ async fn postgres_node_restart() {
 	let node = builder
 		.build_with_postgres_store(
 			node_entropy,
-			&connection_string,
+			connection_string.clone(),
 			Some("restart_test".to_string()),
 		)
 		.unwrap();