fix(cbf): stop chain source before waiting on tasks

- Stop runtime-dependent chain sources before waiting for non-cancellable background tasks.

- Allow the CBF requester shutdown to unblock the node run loop during Node::stop.

Author: febyeji

src/lib.rs

@@ -735,13 +735,15 @@ impl Node {
 		self.peer_manager.disconnect_all_peers();
 		log_debug!(self.logger, "Disconnected all network peers.");
 
-		// Wait until non-cancellable background tasks (mod LDK's background processor) are done.
-		self.runtime.wait_on_background_tasks();
-
-		// Stop any runtime-dependant chain sources.
+		// Stop any runtime-dependant chain sources before waiting on non-cancellable
+		// background tasks. Some chain sources own background tasks that only exit
+		// after their client/requester is shut down.
 		self.chain_source.stop();
 		log_debug!(self.logger, "Stopped chain sources.");
 
+		// Wait until non-cancellable background tasks (mod LDK's background processor) are done.
+		self.runtime.wait_on_background_tasks();
+
 		// Stop the background processor.
 		self.background_processor_stop_sender
 			.send(())