Use cancellable task for inbound connections

joostjager · joostjager · commit 11b7eb5f8976 · 2025-09-30T09:27:15.000+02:00
So that we'll cleanly signal and wait for termination.
diff --git a/src/lib.rs b/src/lib.rs
@@ -313,6 +313,7 @@ impl Node {
 				bind_addrs.extend(resolved_address);
 			}
 
+			let runtime = Arc::clone(&self.runtime);
 			self.runtime.spawn_cancellable_background_task(async move {
 				{
 				let listener =
@@ -338,7 +339,7 @@ impl Node {
 						}
 						res = listener.accept() => {
 							let tcp_stream = res.unwrap().0;
-							tokio::spawn(async move {
+							runtime.spawn_cancellable_background_task(async move {
 								lightning_net_tokio::setup_inbound(
 									Arc::clone(&peer_mgr),
 									tcp_stream.into_std().unwrap(),

Original file line number	Diff line number	Diff line change
`@@ -313,6 +313,7 @@ impl Node {`
`313`	`313`	`bind_addrs.extend(resolved_address);`
`314`	`314`	`}`
`315`	`315`
	`316`	`+ let runtime = Arc::clone(&self.runtime);`
`316`	`317`	`self.runtime.spawn_cancellable_background_task(async move {`
`317`	`318`	`{`
`318`	`319`	`let listener =`
`@@ -338,7 +339,7 @@ impl Node {`
`338`	`339`	`}`
`339`	`340`	`res = listener.accept() => {`
`340`	`341`	`let tcp_stream = res.unwrap().0;`
`341`		`- tokio::spawn(async move {`
	`342`	`+ runtime.spawn_cancellable_background_task(async move {`
`342`	`343`	`lightning_net_tokio::setup_inbound(`
`343`	`344`	`Arc::clone(&peer_mgr),`
`344`	`345`	`tcp_stream.into_std().unwrap(),`