fix: ensure seed file creation does not fail

Seed file generation failed if the parent directory did not exist.
This is an existing bug that was masked by the implicit creation
of the parent directory by the former `FilesystemLogger`.

While the new `Logger` maintains this behaviour, it only created
the parent directory for the default log file path. As a result, if the
node's configured storage directory differed from the default, seed
file creation would fail.

This fix addresses this bug as well as modifies the logger
setup logic to ensure that the Node's configured storage directory
is created, not just the default storage directory.

Author: enigbe

src/builder.rs

@@ -7,7 +7,7 @@
 
 use crate::chain::{ChainSource, DEFAULT_ESPLORA_SERVER_URL};
 use crate::config::{
-	default_user_config, Config, EsploraSyncConfig, FilesystemLoggerConfig, DEFAULT_LOG_FILE_PATH,
+	default_user_config, Config, EsploraSyncConfig, FilesystemLoggerConfig, DEFAULT_LOG_FILENAME,
 	DEFAULT_LOG_LEVEL, WALLET_KEYS_SEED_LEN,
 };
 
@@ -432,7 +432,7 @@ impl NodeBuilder {
 	) -> Result<Node, BuildError> {
 		use bitcoin::key::Secp256k1;
 
-		let logger = setup_logger(&self.log_writer_config)?;
+		let logger = setup_logger(&self.log_writer_config, &self.config)?;
 
 		let seed_bytes = seed_bytes_from_config(
 			&self.config,
@@ -497,7 +497,7 @@ impl NodeBuilder {
 	pub fn build_with_vss_store_and_header_provider(
 		&self, vss_url: String, store_id: String, header_provider: Arc<dyn VssHeaderProvider>,
 	) -> Result<Node, BuildError> {
-		let logger = setup_logger(&self.log_writer_config)?;
+		let logger = setup_logger(&self.log_writer_config, &self.config)?;
 
 		let seed_bytes = seed_bytes_from_config(
 			&self.config,
@@ -529,7 +529,7 @@ impl NodeBuilder {
 
 	/// Builds a [`Node`] instance according to the options previously configured.
 	pub fn build_with_store(&self, kv_store: Arc<DynStore>) -> Result<Node, BuildError> {
-		let logger = setup_logger(&self.log_writer_config)?;
+		let logger = setup_logger(&self.log_writer_config, &self.config)?;
 
 		let seed_bytes = seed_bytes_from_config(
 			&self.config,
@@ -1293,17 +1293,21 @@ fn build_with_store_internal(
 }
 
 /// Sets up the node logger.
-fn setup_logger(config_opt: &Option<LogWriterConfig>) -> Result<Arc<Logger>, BuildError> {
-	let default_config = LogWriterConfig::default();
-	let config = if let Some(conf) = config_opt { conf } else { &default_config };
-
-	let logger = match config {
+///
+/// If `log_writer_conf` is set to None, uses [`LogWriterConfig::default()`].
+/// The `node_conf`is provided to access the configured storage directory.
+fn setup_logger(
+	log_writer_conf: &Option<LogWriterConfig>, node_conf: &Config,
+) -> Result<Arc<Logger>, BuildError> {
+	let default_lw_config = LogWriterConfig::default();
+	let log_writer_config =
+		if let Some(conf) = log_writer_conf { conf } else { &default_lw_config };
+
+	let logger = match log_writer_config {
 		LogWriterConfig::File(fs_logger_config) => {
-			let log_file_path = if let Some(fp) = &fs_logger_config.log_file_path {
-				fp
-			} else {
-				DEFAULT_LOG_FILE_PATH
-			};
+			let fp = format!("{}/{}", node_conf.storage_dir_path, DEFAULT_LOG_FILENAME);
+			let log_file_path =
+				if let Some(fp) = &fs_logger_config.log_file_path { fp } else { &fp };
 			let log_level = fs_logger_config.log_level.unwrap_or(DEFAULT_LOG_LEVEL);
 
 			Logger::new_fs_writer(log_file_path, log_level)

src/config.rs

@@ -33,8 +33,8 @@ const DEFAULT_ANCHOR_PER_CHANNEL_RESERVE_SATS: u64 = 25_000;
 /// The default log level.
 pub const DEFAULT_LOG_LEVEL: LogLevel = LogLevel::Debug;
 
-/// The default log file path.
-pub const DEFAULT_LOG_FILE_PATH: &'static str = "/tmp/ldk_node/ldk_node.log";
+/// The default log filename.
+pub const DEFAULT_LOG_FILENAME: &'static str = "ldk_node.log";
 
 // The 'stop gap' parameter used by BDK's wallet sync. This seems to configure the threshold
 // number of derivation indexes after which BDK stops looking for new scripts belonging to the wallet.
@@ -440,7 +440,7 @@ pub struct FilesystemLoggerConfig {
 	///
 	/// This specifies the log file path if a destination other than the storage
 	/// directory, i.e. [`Config::storage_dir_path`], is preferred. If unconfigured,
-	/// defaults to [`DEFAULT_LOG_FILE_PATH`]
+	/// defaults to [`DEFAULT_LOG_FILENAME`] in default storage directory.
 	pub log_file_path: Option<String>,
 	/// This specifies the log level.
 	///
@@ -451,7 +451,7 @@ pub struct FilesystemLoggerConfig {
 impl Default for FilesystemLoggerConfig {
 	fn default() -> Self {
 		Self {
-			log_file_path: Some(DEFAULT_LOG_FILE_PATH.to_string()),
+			log_file_path: Some(format!("{}/{}", DEFAULT_STORAGE_DIR_PATH, DEFAULT_LOG_FILENAME)),
 			log_level: Some(DEFAULT_LOG_LEVEL),
 		}
 	}

src/io/utils.rs

@@ -98,6 +98,17 @@ where
 		let mut key = [0; WALLET_KEYS_SEED_LEN];
 		thread_rng().fill_bytes(&mut key);
 
+		if let Some(parent_dir) = Path::new(&keys_seed_path).parent() {
+			fs::create_dir_all(parent_dir).map_err(|e| {
+				log_error!(
+					logger,
+					"Failed to create parent directory for key seed file: {}.",
+					keys_seed_path
+				);
+				e
+			})?;
+		}
+
 		let mut f = fs::File::create(keys_seed_path).map_err(|e| {
 			log_error!(logger, "Failed to create keys seed file: {}", keys_seed_path);
 			e