Remove single transaction vecs in wallet broadcast path

Author: tankyleo

src/tx_broadcaster.rs

@@ -33,8 +33,8 @@ impl BroadcastPackage {
 	}
 
 	/// Builds a package for wallet-originated broadcasts that have no LDK classification.
-	fn unclassified(txs: Vec<Transaction>) -> Self {
-		Self(txs.into_iter().map(|tx| (tx, None)).collect())
+	fn unclassified(tx: Transaction) -> Self {
+		Self(vec![(tx, None)])
 	}
 
 	/// The packaged transactions and their types, for classification.
@@ -106,8 +106,8 @@ where
 		Ok(package)
 	}
 
-	pub(crate) fn broadcast_unclassified_transactions(&self, txs: Vec<Transaction>) {
-		self.queue_sender.try_send(BroadcastPackage::unclassified(txs)).unwrap_or_else(|e| {
+	pub(crate) fn broadcast_unclassified_transaction(&self, tx: Transaction) {
+		self.queue_sender.try_send(BroadcastPackage::unclassified(tx)).unwrap_or_else(|e| {
 			log_error!(self.logger, "Failed to broadcast transactions: {}", e);
 		});
 	}

src/wallet/mod.rs

@@ -330,7 +330,7 @@ impl Wallet {
 						.into_iter()
 						.filter_map(|txid| {
 							let tx = locked_wallet.tx_details(txid).map(|d| (*d.tx).clone())?;
-							self.broadcaster.broadcast_unclassified_transactions(vec![tx]);
+							self.broadcaster.broadcast_unclassified_transaction(tx);
 							Some(())
 						})
 						.count();
@@ -878,7 +878,7 @@ impl Wallet {
 		};
 
 		let txid = tx.compute_txid();
-		self.broadcaster.broadcast_unclassified_transactions(vec![tx]);
+		self.broadcaster.broadcast_unclassified_transaction(tx);
 
 		match send_amount {
 			OnchainSendAmount::ExactRetainingReserve { amount_sats, .. } => {
@@ -1758,7 +1758,7 @@ impl Wallet {
 		self.runtime
 			.block_on(self.pending_payment_store.insert_or_update(pending_payment_store))?;
 
-		self.broadcaster.broadcast_unclassified_transactions(vec![fee_bumped_tx]);
+		self.broadcaster.broadcast_unclassified_transaction(fee_bumped_tx);
 
 		log_info!(self.logger, "RBF successful: replaced {} with {}", txid, new_txid);