Keep pending payment details internal

Stop exporting the pending payment index record from the public
payment module.

The pending index is an internal persistence detail and should not
become public API before this ships.

Co-Authored-By: HAL 9000

Author: tnull

src/payment/mod.rs

@@ -20,7 +20,7 @@ pub use bolt11::Bolt11Payment;
 pub(crate) use bolt11::PaymentMetadata;
 pub use bolt12::Bolt12Payment;
 pub use onchain::OnchainPayment;
-pub use pending_payment_store::PendingPaymentDetails;
+pub(crate) use pending_payment_store::PendingPaymentDetails;
 pub use spontaneous::SpontaneousPayment;
 pub use store::{
 	ConfirmationStatus, LSPS2Parameters, PaymentDetails, PaymentDirection, PaymentKind,

src/payment/pending_payment_store.rs

@@ -26,11 +26,6 @@ impl PendingPaymentDetails {
 	pub(crate) fn new(details: PaymentDetails, conflicting_txids: Vec<Txid>) -> Self {
 		Self { details, conflicting_txids }
 	}
-
-	/// Convert to finalized payment for the main payment store
-	pub fn into_payment_details(self) -> PaymentDetails {
-		self.details
-	}
 }
 
 impl_writeable_tlv_based!(PendingPaymentDetails, {