f Allow idempotent inbound BOLT12 hashes

Permit existing inbound BOLT12 records to accept an unchanged hash
when failing a claimable payment. The remaining assertion still prevents
changing an established hash.

Co-Authored-By: HAL 9000

Author: tnull

src/payment/store.rs

@@ -181,11 +181,6 @@ impl StorableObject for PaymentDetails {
 		if let Some(hash_opt) = update.hash {
 			match self.kind {
 				PaymentKind::Bolt12Offer { ref mut hash, .. } => {
-					debug_assert_eq!(
-						self.direction,
-						PaymentDirection::Outbound,
-						"We should only ever override payment hash for outbound BOLT 12 payments"
-					);
 					debug_assert!(
 						hash.is_none() || *hash == hash_opt,
 						"We should never change a payment hash after being initially set"