Rename field to LSPS2ServiceConfig::disable_client_reserve

Author: tankyleo

src/liquidity.rs

@@ -145,7 +145,7 @@ pub struct LSPS2ServiceConfig {
 	/// When set, we will allow clients to spend their entire channel balance in the channels
 	/// we open to them. This allows clients to try to steal your channel balance with
 	/// no financial penalty, so this should only be set if you trust your clients.
-	pub allow_client_0reserve: bool,
+	pub disable_client_reserve: bool,
 }
 
 pub(crate) struct LiquiditySourceBuilder<L: Deref>
@@ -792,7 +792,7 @@ where
 				config.channel_config.forwarding_fee_base_msat = 0;
 				config.channel_config.forwarding_fee_proportional_millionths = 0;
 
-				let result = if service_config.allow_client_0reserve {
+				let result = if service_config.disable_client_reserve {
 					self.channel_manager.create_channel_to_trusted_peer_0reserve(
 						their_network_key,
 						channel_amount_sats,
@@ -819,7 +819,7 @@ where
 						// the pending requests and regularly retry opening the channel until we
 						// succeed.
 						let zero_reserve_string =
-							if service_config.allow_client_0reserve { "0reserve " } else { "" };
+							if service_config.disable_client_reserve { "0reserve " } else { "" };
 						log_error!(
 							self.logger,
 							"Failed to open LSPS2 {}channel to {}: {:?}",

tests/integration_tests_rust.rs

@@ -1786,7 +1786,7 @@ async fn do_lsps2_client_service_integration(client_trusts_lsp: bool) {
 		min_channel_opening_fee_msat: 0,
 		max_client_to_self_delay: 1024,
 		client_trusts_lsp,
-		allow_client_0reserve: false,
+		disable_client_reserve: false,
 	};
 
 	let service_config = random_config(true);
@@ -2105,7 +2105,7 @@ async fn lsps2_client_trusts_lsp() {
 		min_channel_opening_fee_msat: 0,
 		max_client_to_self_delay: 1024,
 		client_trusts_lsp: true,
-		allow_client_0reserve: false,
+		disable_client_reserve: false,
 	};
 
 	let service_config = random_config(true);
@@ -2280,7 +2280,7 @@ async fn lsps2_lsp_trusts_client_but_client_does_not_claim() {
 		min_channel_opening_fee_msat: 0,
 		max_client_to_self_delay: 1024,
 		client_trusts_lsp: false,
-		allow_client_0reserve: false,
+		disable_client_reserve: false,
 	};
 
 	let service_config = random_config(true);