f - Monitor v0.7.0 serialization downgrade compatibility

Assert that pre-downgrade BOLT 11 payment records remain readable after reopening with v0.7.0.

Co-Authored-By: HAL 9000

Author: tnull

tests/upgrade_downgrade_tests.rs

@@ -62,6 +62,7 @@ async fn monitor_v0_7_0_serialization_downgrade_channel_payment() {
 
 	let node_id_a;
 	let node_id_b;
+	let pre_downgrade_payment_id;
 
 	{
 		let node_a = build_current_node(
@@ -105,8 +106,13 @@ async fn monitor_v0_7_0_serialization_downgrade_channel_payment() {
 		assert_current_channel_ready(&node_a, node_id_b);
 		assert_current_channel_ready(&node_b, node_id_a);
 
-		send_current_bolt11_payment(&node_a, &node_b, PRE_DOWNGRADE_PAYMENT_MSAT, "pre-downgrade")
-			.await;
+		pre_downgrade_payment_id = send_current_bolt11_payment(
+			&node_a,
+			&node_b,
+			PRE_DOWNGRADE_PAYMENT_MSAT,
+			"pre-downgrade",
+		)
+		.await;
 
 		node_a.stop().unwrap();
 		node_b.stop().unwrap();
@@ -130,6 +136,21 @@ async fn monitor_v0_7_0_serialization_downgrade_channel_payment() {
 	assert_eq!(node_a_v070.node_id(), node_id_a);
 	assert_eq!(node_b_v070.node_id(), node_id_b);
 
+	let pre_downgrade_payment_id =
+		ldk_node_070::lightning::ln::channelmanager::PaymentId(pre_downgrade_payment_id.0);
+	assert_v070_bolt11_payment(
+		&node_a_v070,
+		&pre_downgrade_payment_id,
+		ldk_node_070::payment::PaymentDirection::Outbound,
+		PRE_DOWNGRADE_PAYMENT_MSAT,
+	);
+	assert_v070_bolt11_payment(
+		&node_b_v070,
+		&pre_downgrade_payment_id,
+		ldk_node_070::payment::PaymentDirection::Inbound,
+		PRE_DOWNGRADE_PAYMENT_MSAT,
+	);
+
 	node_a_v070.sync_wallets().unwrap();
 	node_b_v070.sync_wallets().unwrap();
 	node_a_v070.connect(node_id_b, v070_addresses_b.first().unwrap().clone(), true).unwrap();
@@ -217,7 +238,7 @@ async fn open_current_channel(node_a: &CurrentNode, node_b: &CurrentNode) -> bit
 
 async fn send_current_bolt11_payment(
 	payer: &CurrentNode, payee: &CurrentNode, amount_msat: u64, description: &str,
-) {
+) -> ldk_node::lightning::ln::channelmanager::PaymentId {
 	let invoice_description = CurrentBolt11InvoiceDescription::Direct(
 		CurrentDescription::new(description.to_owned()).unwrap(),
 	);
@@ -229,6 +250,7 @@ async fn send_current_bolt11_payment(
 		payer.payment(&payment_id).unwrap().status,
 		ldk_node::payment::PaymentStatus::Succeeded
 	);
+	payment_id
 }
 
 async fn send_v070_bolt11_payment(
@@ -363,6 +385,17 @@ fn assert_current_channel_ready(node: &CurrentNode, counterparty_node_id: Public
 	assert!(channel.is_channel_ready);
 }
 
+fn assert_v070_bolt11_payment(
+	node: &ldk_node_070::Node, payment_id: &ldk_node_070::lightning::ln::channelmanager::PaymentId,
+	expected_direction: ldk_node_070::payment::PaymentDirection, expected_amount_msat: u64,
+) {
+	let payment = node.payment(payment_id).unwrap();
+	assert_eq!(payment.amount_msat, Some(expected_amount_msat));
+	assert_eq!(payment.direction, expected_direction);
+	assert_eq!(payment.status, ldk_node_070::payment::PaymentStatus::Succeeded);
+	assert!(matches!(payment.kind, ldk_node_070::payment::PaymentKind::Bolt11 { .. }));
+}
+
 fn to_v070_socket_addresses(
 	addresses: &[CurrentSocketAddress],
 ) -> Vec<ldk_node_070::lightning::ln::msgs::SocketAddress> {