test: Fix announcement address assertion and simplify stress test

Read node_b's listening addresses from the node after setup instead of
using the pre-retry variable, which may differ if setup_node retried
with new ports.

Simplify the stress test to run 1 process per shard with 10 iterations
instead of 3 concurrent processes. The concurrent processes caused port
collisions in code paths outside setup_node that don't have retry logic,
which is noise unrelated to the electrs crash we're investigating.

AI tools were used in preparing this commit.

Author: joostjager

.github/workflows/rust.yml

@@ -130,29 +130,18 @@ jobs:
           echo "ELECTRS_EXE=$( pwd )/bin/electrs-${{ runner.os }}-${{ runner.arch }}" >> "$GITHUB_ENV"
       - name: Build integration tests
         run: RUSTFLAGS="--cfg no_download --cfg cycle_tests" cargo test --test integration_tests_rust --no-run
-      - name: Stress-test integration tests (5 iterations, 3 concurrent processes)
+      - name: Stress-test integration tests (10 iterations)
         run: |
-          for i in $(seq 1 5); do
+          for i in $(seq 1 10); do
             echo "=== Iteration $i (shard ${{ matrix.shard }}) ==="
-            for j in 1 2 3; do
-              RUSTFLAGS="--cfg no_download --cfg cycle_tests" cargo test --test integration_tests_rust -- --nocapture > /tmp/stress-${j}.log 2>&1 &
-              pids[${j}]=$!
-            done
-            failed=0
-            for j in 1 2 3; do
-              if ! wait ${pids[${j}]}; then
-                echo "FAILED: process $j on iteration $i (shard ${{ matrix.shard }})"
-                cat /tmp/stress-${j}.log
-                failed=1
-              fi
-            done
-            if [ $failed -eq 1 ]; then
+            RUSTFLAGS="--cfg no_download --cfg cycle_tests" cargo test --test integration_tests_rust -- --nocapture 2>&1 || {
+              echo "FAILED on iteration $i (shard ${{ matrix.shard }})"
               echo "=== dmesg OOM/kill messages ==="
               sudo dmesg | grep -iE 'oom|kill|out of memory|invoked oom' || echo "No OOM messages found"
               echo "=== dmesg last 50 lines ==="
               sudo dmesg | tail -50
               exit 1
-            fi
+            }
           done
 
   doc:

tests/integration_tests_rust.rs

@@ -1443,13 +1443,12 @@ async fn test_node_announcement_propagation() {
 	node_b_alias_bytes[..node_b_alias_string.as_bytes().len()]
 		.copy_from_slice(node_b_alias_string.as_bytes());
 	let node_b_node_alias = Some(NodeAlias(node_b_alias_bytes));
-	let node_b_listening_addresses = random_listening_addresses();
 	config_b.node_config.node_alias = node_b_node_alias.clone();
-	config_b.node_config.listening_addresses = Some(node_b_listening_addresses.clone());
 	config_b.node_config.announcement_addresses = None;
 
 	let node_a = setup_node(&chain_source, config_a);
 	let node_b = setup_node(&chain_source, config_b);
+	let node_b_listening_addresses = node_b.listening_addresses().unwrap();
 
 	let address_a = node_a.onchain_payment().new_address().unwrap();
 	let premine_amount_sat = 5_000_000;