fixup! feat: introduce and configure node with tiered KVStore

remove features relating to retry configuration and reading/listing from backup store as a fallback strategy

Author: enigbe

bindings/ldk_node.udl

@@ -79,12 +79,6 @@ enum WordCount {
 	"Words24",
 };
 
-dictionary RetryConfig {
-	u16 initial_retry_delay_ms;
-	u16 maximum_delay_ms;
-	f32 backoff_multiplier;
-};
-
 enum LogLevel {
 	"Gossip",
 	"Trace",
@@ -180,7 +174,6 @@ interface Builder {
 	void set_announcement_addresses(sequence<SocketAddress> announcement_addresses);
 	[Throws=BuildError]
 	void set_node_alias(string node_alias);
-	void set_tier_store_retry_config(RetryConfig retry_config);
 	void set_tier_store_backup(FfiDynStore backup_store);
 	void set_tier_store_ephemeral(FfiDynStore ephemeral_store);
 	[Throws=BuildError]

bindings/python/src/ldk_node/test_ldk_node.py

@@ -168,12 +168,7 @@ def setup_node_with_tier_store(tmp_dir, esplora_endpoint, listening_addresses):
     primary = TestKvStore("primary")
     backup = TestKvStore("backup")
     ephemeral = TestKvStore("ephemeral")
-    retry_config = RetryConfig(
-        initial_retry_delay_ms=10, 
-        maximum_delay_ms=100, 
-        backoff_multiplier=2.0
-    )
-
+    
     # Set event loop for async Python callbacks from Rust
     # (https://mozilla.github.io/uniffi-rs/0.27/futures.html#python-uniffi_set_event_loop)
     loop = asyncio.new_event_loop()
@@ -191,7 +186,6 @@ def run_loop():
     builder.set_chain_source_esplora(esplora_endpoint, None)
     builder.set_network(DEFAULT_TEST_NETWORK)
     builder.set_listening_addresses(listening_addresses)
-    builder.set_tier_store_retry_config(retry_config)
     builder.set_tier_store_backup(FfiDynStore.from_store(backup))
     builder.set_tier_store_ephemeral(FfiDynStore.from_store(ephemeral))
 

src/builder.rs

@@ -56,7 +56,7 @@ use crate::fee_estimator::OnchainFeeEstimator;
 use crate::ffi::FfiDynStore;
 use crate::gossip::GossipSource;
 use crate::io::sqlite_store::SqliteStore;
-use crate::io::tier_store::{RetryConfig, TierStore};
+use crate::io::tier_store::TierStore;
 use crate::io::utils::{
 	read_event_queue, read_external_pathfinding_scores_from_cache, read_network_graph,
 	read_node_metrics, read_output_sweeper, read_payments, read_peer_info, read_pending_payments,
@@ -157,15 +157,13 @@ impl std::fmt::Debug for LogWriterConfig {
 struct TierStoreConfig {
 	ephemeral: Option<Arc<DynStore>>,
 	backup: Option<Arc<DynStore>>,
-	retry: Option<RetryConfig>,
 }
 
 impl std::fmt::Debug for TierStoreConfig {
 	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
 		f.debug_struct("TierStoreConfig")
 			.field("ephemeral", &self.ephemeral.as_ref().map(|_| "Arc<DynStore>"))
 			.field("backup", &self.backup.as_ref().map(|_| "Arc<DynStore>"))
-			.field("retry", &self.retry)
 			.finish()
 	}
 }
@@ -567,21 +565,6 @@ impl NodeBuilder {
 		Ok(self)
 	}
 
-	/// Configures retry behavior for transient errors when accessing the primary store.
-	///
-	/// When building with [`build_with_tier_store`], controls the exponential backoff parameters
-	/// used when retrying failed operations on the primary store due to transient errors
-	/// (network issues, timeouts, etc.).
-	///
-	/// If not set, default retry parameters are used. See [`RetryConfig`] for details.
-	///
-	/// [`build_with_tier_store`]: Self::build_with_tier_store
-	pub fn set_tier_store_retry_config(&mut self, config: RetryConfig) -> &mut Self {
-		let tier_store_config = self.tier_store_config.get_or_insert(TierStoreConfig::default());
-		tier_store_config.retry = Some(config);
-		self
-	}
-
 	/// Configures the backup store for local disaster recovery.
 	///
 	/// When building with [`build_with_tier_store`], this store receives asynchronous copies
@@ -744,37 +727,32 @@ impl NodeBuilder {
 	///
 	/// ## Configuration
 	///
-	/// Use the setter methods to configure optional stores and retry behavior:
+	/// Use the setter methods to configure optional stores:
 	/// - [`set_tier_store_ephemeral`] - Set local store for network graph and scorer
 	/// - [`set_tier_store_backup`] - Set local backup store for disaster recovery
-	/// - [`set_tier_store_retry_config`] - Configure retry delays and backoff for transient errors
 	///
 	/// ## Example
 	///
 	/// ```ignore
 	/// # use ldk_node::{Builder, Config};
-	/// # use ldk_node::io::tier_store::RetryConfig;
 	/// # use std::sync::Arc;
 	/// let config = Config::default();
 	/// let mut builder = NodeBuilder::from_config(config);
 	///
 	/// let primary = Arc::new(VssStore::new(...));
 	/// let ephemeral = Arc::new(FilesystemStore::new(...));
 	/// let backup = Arc::new(SqliteStore::new(...));
-	///	let retry_config = RetryConfig::default();
 	///
 	/// builder
 	///     .set_tier_store_ephemeral(ephemeral)
-	///     .set_tier_store_backup(backup)
-	/// 	.set_tier_store_retry_config(retry_config);
+	///     .set_tier_store_backup(backup);
 	///
 	/// let node = builder.build_with_tier_store(primary)?;
 	/// # Ok::<(), ldk_node::BuildError>(())
 	/// ```
 	///
 	/// [`set_tier_store_ephemeral`]: Self::set_tier_store_ephemeral
 	/// [`set_tier_store_backup`]: Self::set_tier_store_backup
-	/// [`set_tier_store_retry_config`]: Self::set_tier_store_retry_config
 	#[cfg(not(feature = "uniffi"))]
 	pub fn build_with_tier_store(
 		&self, node_entropy: NodeEntropy, primary_store: Arc<DynStore>,
@@ -796,10 +774,9 @@ impl NodeBuilder {
 		};
 
 		let ts_config = self.tier_store_config.as_ref();
-		let retry_config = ts_config.and_then(|c| c.retry).unwrap_or_default();
 
 		let mut tier_store =
-			TierStore::new(primary_store, Arc::clone(&runtime), Arc::clone(&logger), retry_config);
+			TierStore::new(primary_store, Arc::clone(&runtime), Arc::clone(&logger));
 
 		if let Some(config) = ts_config {
 			config.ephemeral.as_ref().map(|s| tier_store.set_ephemeral_store(Arc::clone(s)));
@@ -1074,19 +1051,6 @@ impl ArcedNodeBuilder {
 		self.inner.write().unwrap().set_async_payments_role(role).map(|_| ())
 	}
 
-	/// Configures retry behavior for transient errors when accessing the primary store.
-	///
-	/// When building with [`build_with_tier_store`], controls the exponential backoff parameters
-	/// used when retrying failed operations on the primary store due to transient errors
-	/// (network issues, timeouts, etc.).
-	///
-	/// If not set, default retry parameters are used. See [`RetryConfig`] for details.
-	///
-	/// [`build_with_tier_store`]: Self::build_with_tier_store
-	pub fn set_tier_store_retry_config(&self, config: RetryConfig) {
-		self.inner.write().unwrap().set_tier_store_retry_config(config);
-	}
-
 	/// Configures the backup store for local disaster recovery.
 	///
 	/// When building with [`build_with_tier_store`], this store receives asynchronous copies