Finish async node API migration

Expose startup, shutdown, builder, wallet, liquidity, and bindings entrypoints as async so store-backed persistence no longer needs local synchronous future driving. Update tests and benches to await the async surface and keep store persistence helpers on the async storage path.

Co-Authored-By: HAL 9000

Author: tnull

benches/payments.rs

@@ -35,14 +35,15 @@ fn spawn_payment(node_a: Arc<Node>, node_b: Arc<Node>, amount_msat: u64) {
 				tokio::time::sleep(std::time::Duration::from_millis(100)).await;
 			}
 
-			let payment_id = node_a.spontaneous_payment().send_with_preimage(
+			let spontaneous_payment = node_a.spontaneous_payment();
+			let payment_id = spontaneous_payment.send_with_preimage(
 				amount_msat,
 				node_b.node_id(),
 				preimage,
 				None,
 			);
 
-			match payment_id {
+			match payment_id.await {
 				Ok(payment_id) => {
 					println!(
 						"{}: Awaiting payment with id {}",
@@ -93,7 +94,7 @@ async fn send_payments(node_a: Arc<Node>, node_b: Arc<Node>) -> std::time::Durat
 			},
 		}
 
-		node_a.event_handled().unwrap();
+		node_a.event_handled().await.unwrap();
 	}
 
 	let duration = start.elapsed();
@@ -110,37 +111,36 @@ async fn send_payments(node_a: Arc<Node>, node_b: Arc<Node>) -> std::time::Durat
 			PaymentPreimage(preimage_bytes),
 			None,
 		)
+		.await
 		.ok()
 		.unwrap();
 
 	duration
 }
 
 fn payment_benchmark(c: &mut Criterion) {
-	// Set up two nodes. Because this is slow, we reuse the same nodes for each sample.
-	let (bitcoind, electrsd) = setup_bitcoind_and_electrsd();
-	let chain_source = random_chain_source(&bitcoind, &electrsd);
-
-	let (node_a, node_b) = setup_two_nodes_with_store(
-		&chain_source,
-		false,
-		true,
-		false,
-		common::TestStoreType::Sqlite,
-	);
-
 	let runtime =
 		tokio::runtime::Builder::new_multi_thread().worker_threads(4).enable_all().build().unwrap();
 
-	let node_a = Arc::new(node_a);
-	let node_b = Arc::new(node_b);
+	// Set up two nodes. Because this is slow, we reuse the same nodes for each sample.
+	let (setup_done, setup_result) = std::sync::mpsc::channel();
+	runtime.spawn(async move {
+		let (bitcoind, electrsd) = setup_bitcoind_and_electrsd();
+		let chain_source = random_chain_source(&bitcoind, &electrsd);
+		let (node_a, node_b) = setup_two_nodes_with_store(
+			&chain_source,
+			false,
+			true,
+			false,
+			common::TestStoreType::Sqlite,
+		)
+		.await;
+
+		let node_a = Arc::new(node_a);
+		let node_b = Arc::new(node_b);
 
-	// Fund the nodes and setup a channel between them. The criterion function cannot be async, so we need to execute
-	// the setup using a runtime.
-	let node_a_cloned = Arc::clone(&node_a);
-	let node_b_cloned = Arc::clone(&node_b);
-	runtime.block_on(async move {
-		let address_a = node_a_cloned.onchain_payment().new_address().unwrap();
+		// Fund the nodes and setup a channel between them.
+		let address_a = node_a.onchain_payment().new_address().await.unwrap();
 		let premine_sat = 25_000_000;
 		premine_and_distribute_funds(
 			&bitcoind.client,
@@ -149,23 +149,18 @@ fn payment_benchmark(c: &mut Criterion) {
 			Amount::from_sat(premine_sat),
 		)
 		.await;
-		node_a_cloned.sync_wallets().unwrap();
-		node_b_cloned.sync_wallets().unwrap();
-		open_channel_push_amt(
-			&node_a_cloned,
-			&node_b_cloned,
-			16_000_000,
-			Some(1_000_000_000),
-			false,
-			&electrsd,
-		)
-		.await;
+		node_a.sync_wallets().await.unwrap();
+		node_b.sync_wallets().await.unwrap();
+		open_channel_push_amt(&node_a, &node_b, 16_000_000, Some(1_000_000_000), false, &electrsd)
+			.await;
 		generate_blocks_and_wait(&bitcoind.client, &electrsd.client, 6).await;
-		node_a_cloned.sync_wallets().unwrap();
-		node_b_cloned.sync_wallets().unwrap();
-		expect_channel_ready_event!(node_a_cloned, node_b_cloned.node_id());
-		expect_channel_ready_event!(node_b_cloned, node_a_cloned.node_id());
+		node_a.sync_wallets().await.unwrap();
+		node_b.sync_wallets().await.unwrap();
+		expect_channel_ready_event!(node_a, node_b.node_id());
+		expect_channel_ready_event!(node_b, node_a.node_id());
+		setup_done.send((node_a, node_b)).unwrap();
 	});
+	let (node_a, node_b) = setup_result.recv().unwrap();
 
 	let mut group = c.benchmark_group("payments");
 	group.sample_size(10);

bindings/ldk_node.udl

@@ -61,35 +61,36 @@ interface Builder {
 	[Throws=BuildError]
 	void set_async_payments_role(AsyncPaymentsRole? role);
 	void set_wallet_recovery_mode();
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build(NodeEntropy node_entropy);
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build_with_postgres_store(NodeEntropy node_entropy, string connection_string, string? db_name, string? kv_table_name, string? certificate_pem);
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build_with_fs_store(NodeEntropy node_entropy);
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build_with_vss_store(NodeEntropy node_entropy, string vss_url, string store_id, record<string, string> fixed_headers);
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build_with_vss_store_and_lnurl_auth(NodeEntropy node_entropy, string vss_url, string store_id, string lnurl_auth_server_url, record<string, string> fixed_headers);
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build_with_vss_store_and_fixed_headers(NodeEntropy node_entropy, string vss_url, string store_id, record<string, string> fixed_headers);
-	[Throws=BuildError]
+	[Async, Throws=BuildError]
 	Node build_with_vss_store_and_header_provider(NodeEntropy node_entropy, string vss_url, string store_id, VssHeaderProvider header_provider);
 };
 
 interface Node {
-	[Throws=NodeError]
+	[Async, Throws=NodeError]
 	void start();
-	[Throws=NodeError]
+	[Async, Throws=NodeError]
 	void stop();
 	[Async]
 	NodeStatus status();
 	Config config();
 	Event? next_event();
+	[Async]
 	Event wait_next_event();
 	[Async]
 	Event next_event_async();
-	[Throws=NodeError]
+	[Async, Throws=NodeError]
 	void event_handled();
 	PublicKey node_id();
 	sequence<SocketAddress>? listening_addresses();
@@ -101,7 +102,7 @@ interface Node {
 	OnchainPayment onchain_payment();
 	UnifiedPayment unified_payment();
 	LSPS1Liquidity lsps1_liquidity();
-	[Throws=NodeError]
+	[Async, Throws=NodeError]
 	void lnurl_auth(string lnurl);
 	[Async, Throws=NodeError]
 	void connect(PublicKey node_id, SocketAddress address, boolean persist);