Stop the chain source upon startup checks failure

This is particularly relevant for the electrum chain source; if we fail
to fetch feerates, or zero fee commitments validation fails, and we do
not stop the electrum chain source before returning an error, then the
user will hit a debug assertion on the next restart.

Author: tankyleo

src/lib.rs

@@ -335,14 +335,18 @@ impl Node {
 		//
 		// TODO: drop 0FC chain source validation when support is ubiquitous
 		let chain_source = Arc::clone(&self.chain_source);
-		self.runtime.block_on(async move {
+		let startup_chain_check_res = self.runtime.block_on(async move {
 			tokio::try_join!(
 				chain_source.update_fee_rate_estimates(),
 				chain_source.validate_zero_fee_commitments_support_if_required(
 					zero_fee_commitments_support_required
 				)
 			)
-		})?;
+		});
+		if let Err(e) = startup_chain_check_res {
+			self.chain_source.stop();
+			return Err(e);
+		}
 
 		// Spawn background task continuously syncing onchain, lightning, and fee rate cache.
 		let stop_sync_receiver = self.stop_sender.subscribe();