Skip to content

Implement lazy deletes for VssStore #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tnull merged 3 commits into from
Nov 17, 2025
Merged

Implement lazy deletes for VssStore #689

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20ffc9c
Implement `lazy` deletes for `VssStore`
tnull Oct 31, 2025
db246fc
f Restore delete_items on failed write
tnull Nov 17, 2025
c2b6b18
Add test for `lazy` deletion behavior
tnull Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/io/vss_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,10 +475,15 @@ impl VssStoreInner {
version: vss_version,
value: storable.encode_to_vec(),
}],
delete_items,
delete_items: delete_items.clone(),
};

self.client.put_object(&request).await.map_err(|e| {
// Restore delete items so they'll be retried on next write.
Comment thread
joostjager marked this conversation as resolved.
if !delete_items.is_empty() {
self.pending_lazy_deletes.lock().unwrap().extend(delete_items);
}

let msg = format!(
"Failed to write to key {}/{}/{}: {}",
primary_namespace, secondary_namespace, key, e
Expand Down