Skip to content

Wait for node announcements before asserting them#921

Merged
valentinewallace merged 1 commit into
lightningdevkit:mainfrom
tnull:2026-06-fix-flaky-test
Jun 10, 2026
Merged

Wait for node announcements before asserting them#921
valentinewallace merged 1 commit into
lightningdevkit:mainfrom
tnull:2026-06-fix-flaky-test

Conversation

@tnull

@tnull tnull commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

Avoid assuming that a fixed sleep is enough for gossip propagation when integration tests are running concurrently. The test now waits for both peers' announcements to appear in the opposite graph before checking aliases and addresses.

Co-Authored-By: HAL 9000

@tnull
Wait for node announcements before asserting them
56663d2 
Avoid assuming that a fixed sleep is enough for gossip propagation
when integration tests are running concurrently. The test now waits
for both peers' announcements to appear in the opposite graph before
checking aliases and addresses.

Co-Authored-By: HAL 9000
@ldk-reviews-bot

ldk-reviews-bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 6, 2026

Copy link
Copy Markdown

🔔 1st Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 8, 2026

Copy link
Copy Markdown

🔔 2nd Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@ldk-reviews-bot

ldk-reviews-bot commented Jun 10, 2026

Copy link
Copy Markdown

🔔 3rd Reminder

Hey @valentinewallace! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

@valentinewallace valentinewallace merged commit a2c34cb into lightningdevkit:main Jun 10, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@valentinewallace valentinewallace valentinewallace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tnull @ldk-reviews-bot @valentinewallace