Consistently use PaymentId as hex-string.

Author: G8XSU

ldk-server-protos/src/api.rs

@@ -147,9 +147,9 @@ pub struct Bolt11SendRequest {
 #[allow(clippy::derive_partial_eq_without_eq)]
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct Bolt11SendResponse {
-	/// An identifier used to uniquely identify a payment.
-	#[prost(bytes = "bytes", tag = "1")]
-	pub payment_id: ::prost::bytes::Bytes,
+	/// An identifier used to uniquely identify a payment in hex-encoded form.
+	#[prost(string, tag = "1")]
+	pub payment_id: ::prost::alloc::string::String,
 }
 /// Returns a BOLT12 offer for the given amount, if specified.
 ///
@@ -211,9 +211,9 @@ pub struct Bolt12SendRequest {
 #[allow(clippy::derive_partial_eq_without_eq)]
 #[derive(Clone, PartialEq, ::prost::Message)]
 pub struct Bolt12SendResponse {
-	/// An identifier used to uniquely identify a payment.
-	#[prost(bytes = "bytes", tag = "1")]
-	pub payment_id: ::prost::bytes::Bytes,
+	/// An identifier used to uniquely identify a payment in hex-encoded form.
+	#[prost(string, tag = "1")]
+	pub payment_id: ::prost::alloc::string::String,
 }
 /// Creates a new outbound channel to the given remote node.
 /// See more: <https://docs.rs/ldk-node/latest/ldk_node/struct.Node.html#method.connect_open_channel>

ldk-server-protos/src/proto/api.proto

@@ -145,8 +145,8 @@ message Bolt11SendRequest {
 // When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
 message Bolt11SendResponse {
 
-  // An identifier used to uniquely identify a payment.
-  bytes payment_id = 1;
+  // An identifier used to uniquely identify a payment in hex-encoded form.
+  string payment_id = 1;
 }
 
 // Returns a BOLT12 offer for the given amount, if specified.
@@ -205,8 +205,8 @@ message Bolt12SendRequest {
 // When HttpStatusCode is not OK (non-200), the response `content` contains a serialized `ErrorResponse`.
 message Bolt12SendResponse {
 
-  // An identifier used to uniquely identify a payment.
-  bytes payment_id = 1;
+  // An identifier used to uniquely identify a payment in hex-encoded form.
+  string payment_id = 1;
 }
 
 // Creates a new outbound channel to the given remote node.

ldk-server/src/api/bolt11_send.rs

@@ -1,6 +1,5 @@
 use crate::api::error::LdkServerError;
 use crate::service::Context;
-use bytes::Bytes;
 use ldk_node::lightning_invoice::Bolt11Invoice;
 use ldk_server_protos::api::{Bolt11SendRequest, Bolt11SendResponse};
 use std::str::FromStr;
@@ -20,6 +19,6 @@ pub(crate) fn handle_bolt11_send_request(
 		},
 	}?;
 
-	let response = Bolt11SendResponse { payment_id: Bytes::from(payment_id.0.to_vec()) };
+	let response = Bolt11SendResponse { payment_id: payment_id.to_string() };
 	Ok(response)
 }

ldk-server/src/api/bolt12_send.rs

@@ -1,6 +1,5 @@
 use crate::api::error::LdkServerError;
 use crate::service::Context;
-use bytes::Bytes;
 use ldk_node::lightning::offers::offer::Offer;
 use ldk_server_protos::api::{Bolt12SendRequest, Bolt12SendResponse};
 use std::str::FromStr;
@@ -23,6 +22,6 @@ pub(crate) fn handle_bolt12_send_request(
 		),
 	}?;
 
-	let response = Bolt12SendResponse { payment_id: Bytes::from(payment_id.0.to_vec()) };
+	let response = Bolt12SendResponse { payment_id: payment_id.to_string() };
 	Ok(response)
 }