fix: configuration parsing edge cases and startup panics

Signed-off-by: ABHAY PANDEY <pandeyabhay967@gmail.com>

Author: Ferryx349

ldk-server-cli/src/types.rs

@@ -65,7 +65,7 @@ impl Amount {
 	///
 	/// Returns an error string if the value is not evenly divisible by 1000.
 	pub fn to_sat(self) -> Result<u64, String> {
-		if self.msats % 1000 != 0 {
+		if !self.msats.is_multiple_of(1000) {
 			Err(format!(
 				"amount {}msats is not evenly divisible by 1000, cannot convert to whole satoshis",
 				self.msats

ldk-server/src/api/mod.rs

@@ -145,7 +145,7 @@ pub(crate) fn decode_features(
 		for bit_pos in 0..8u32 {
 			if byte & (1 << bit_pos) != 0 {
 				let bit_number = (byte_idx as u32) * 8 + bit_pos;
-				let is_required = bit_number % 2 == 0;
+				let is_required = bit_number.is_multiple_of(2);
 
 				// Create Features with just this bit set and use Display to get the name.
 				let mut single_bit = vec![0u8; byte_idx + 1];

ldk-server/src/main.rs

@@ -137,7 +137,7 @@ fn main() {
 		},
 	};
 
-	ldk_node_config.storage_dir_path = network_dir.to_str().unwrap().to_string();
+	ldk_node_config.storage_dir_path = network_dir.to_string_lossy().to_string();
 	ldk_node_config.listening_addresses = config_file.listening_addrs;
 	ldk_node_config.announcement_addresses = config_file.announcement_addrs;
 	ldk_node_config.network = config_file.network;
@@ -205,7 +205,7 @@ fn main() {
 
 	builder.set_runtime(runtime.handle().clone());
 
-	let seed_path = storage_dir.join("keys_seed").to_str().unwrap().to_string();
+	let seed_path = storage_dir.join("keys_seed").to_string_lossy().to_string();
 	let node_entropy = match NodeEntropy::from_seed_path(seed_path) {
 		Ok(entropy) => entropy,
 		Err(e) => {
@@ -309,7 +309,7 @@ fn main() {
 
 		let server_config = match get_or_generate_tls_config(
 			config_file.tls_config,
-			storage_dir.to_str().unwrap(),
+			storage_dir.to_string_lossy().as_ref(),
 		) {
 			Ok(config) => config,
 			Err(e) => {

ldk-server/src/util/config.rs

@@ -386,6 +386,10 @@ impl ConfigBuilder {
 		let metrics_enabled = self.metrics_enabled.unwrap_or(false);
 
 		let poll_metrics_interval = self.poll_metrics_interval;
+		
+		if let Some(0) = poll_metrics_interval {
+			return Err(io::Error::new(io::ErrorKind::InvalidInput, "poll_metrics_interval must be greater than 0"));
+		}
 
 		let metrics_username = self.metrics_username;
 		let metrics_password = self.metrics_password;
@@ -597,7 +601,11 @@ fn parse_dns_server_address(addr: &str) -> io::Result<SocketAddress> {
 	if let Ok(sa) = SocketAddress::from_str(addr) {
 		return Ok(sa);
 	}
-	let with_default_port = format!("{}:53", addr);
+	let with_default_port = if addr.contains(':') && !addr.starts_with('[') {
+		format!("[{}]:53", addr)
+	} else {
+		format!("{}:53", addr)
+	};
 	SocketAddress::from_str(&with_default_port).map_err(|e| {
 		io::Error::new(
 			io::ErrorKind::InvalidInput,