Skip to content

Commit ab35447

Browse files
benthecarmanclaude
andcommitted
Update cli for gRPC
Rename rest_service_address to grpc_service_address in CLI config and e2e test harness. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent a112578 commit ab35447

2 files changed

Lines changed: 14 additions & 14 deletions

File tree

ldk-server-cli/src/config.rs

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ use serde::{Deserialize, Serialize};
1414
const DEFAULT_CONFIG_FILE: &str = "config.toml";
1515
const DEFAULT_CERT_FILE: &str = "tls.crt";
1616
const API_KEY_FILE: &str = "api_key";
17-
pub const DEFAULT_REST_SERVICE_ADDRESS: &str = "127.0.0.1:3536";
17+
pub const DEFAULT_GRPC_SERVICE_ADDRESS: &str = "127.0.0.1:3536";
1818

1919
pub fn get_default_data_dir() -> Option<PathBuf> {
2020
#[cfg(target_os = "macos")]
@@ -67,8 +67,8 @@ pub struct TlsConfig {
6767

6868
#[derive(Debug, Deserialize)]
6969
pub struct NodeConfig {
70-
#[serde(default = "default_rest_service_address")]
71-
pub rest_service_address: String,
70+
#[serde(default = "default_grpc_service_address")]
71+
pub grpc_service_address: String,
7272
network: String,
7373
}
7474

@@ -104,20 +104,20 @@ pub fn load_config(path: &PathBuf) -> Result<Config, String> {
104104

105105
pub fn resolve_base_url(cli_base_url: Option<String>, config: Option<&Config>) -> String {
106106
cli_base_url
107-
.or_else(|| config.map(|config| config.node.rest_service_address.clone()))
108-
.unwrap_or_else(default_rest_service_address)
107+
.or_else(|| config.map(|config| config.node.grpc_service_address.clone()))
108+
.unwrap_or_else(default_grpc_service_address)
109109
}
110110

111-
fn default_rest_service_address() -> String {
112-
DEFAULT_REST_SERVICE_ADDRESS.to_string()
111+
fn default_grpc_service_address() -> String {
112+
DEFAULT_GRPC_SERVICE_ADDRESS.to_string()
113113
}
114114

115115
#[cfg(test)]
116116
mod tests {
117-
use super::{resolve_base_url, Config, DEFAULT_REST_SERVICE_ADDRESS};
117+
use super::{resolve_base_url, Config, DEFAULT_GRPC_SERVICE_ADDRESS};
118118

119119
#[test]
120-
fn config_defaults_rest_service_address() {
120+
fn config_defaults_grpc_service_address() {
121121
let config: Config = toml::from_str(
122122
r#"
123123
[node]
@@ -126,7 +126,7 @@ mod tests {
126126
)
127127
.unwrap();
128128

129-
assert_eq!(config.node.rest_service_address, DEFAULT_REST_SERVICE_ADDRESS);
129+
assert_eq!(config.node.grpc_service_address, DEFAULT_GRPC_SERVICE_ADDRESS);
130130
}
131131

132132
#[test]
@@ -135,7 +135,7 @@ mod tests {
135135
r#"
136136
[node]
137137
network = "regtest"
138-
rest_service_address = "127.0.0.1:3002"
138+
grpc_service_address = "127.0.0.1:3002"
139139
"#,
140140
)
141141
.unwrap();
@@ -148,6 +148,6 @@ mod tests {
148148

149149
#[test]
150150
fn resolve_base_url_falls_back_to_default() {
151-
assert_eq!(resolve_base_url(None, None), DEFAULT_REST_SERVICE_ADDRESS);
151+
assert_eq!(resolve_base_url(None, None), DEFAULT_GRPC_SERVICE_ADDRESS);
152152
}
153153
}

ldk-server-cli/src/main.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use clap_complete::{generate, Shell};
1515
use config::{
1616
api_key_path_for_storage_dir, cert_path_for_storage_dir, get_default_api_key_path,
1717
get_default_cert_path, get_default_config_path, load_config, resolve_base_url,
18-
DEFAULT_REST_SERVICE_ADDRESS,
18+
DEFAULT_GRPC_SERVICE_ADDRESS,
1919
};
2020
use hex_conservative::DisplayHex;
2121
use ldk_server_client::client::LdkServerClient;
@@ -86,7 +86,7 @@ struct Cli {
8686
short,
8787
long,
8888
help = format!(
89-
"Base URL of the server. Defaults to config file or {DEFAULT_REST_SERVICE_ADDRESS}"
89+
"Base URL of the server. Defaults to config file or {DEFAULT_GRPC_SERVICE_ADDRESS}"
9090
)
9191
)]
9292
base_url: Option<String>,

0 commit comments

Comments
 (0)