fix clippy

Author: benthecarman

orange-sdk/src/event.rs

@@ -1,5 +1,5 @@
 use crate::logging::Logger;
-use crate::store::{self, PaymentId, TxMetadataStore};
+use crate::store::{self, PaymentId};
 
 use ldk_node::bitcoin::secp256k1::PublicKey;
 use ldk_node::bitcoin::{OutPoint, Txid};
@@ -308,7 +308,6 @@ impl Future for EventFuture {
 #[derive(Clone)]
 pub(crate) struct LdkEventHandler {
 	pub(crate) event_queue: Arc<EventQueue>,
-	pub(crate) tx_metadata: TxMetadataStore,
 	pub(crate) ldk_node: Arc<ldk_node::Node>,
 	pub(crate) payment_receipt_sender: watch::Sender<()>,
 	pub(crate) channel_pending_sender: watch::Sender<u128>,

orange-sdk/src/lib.rs

@@ -564,7 +564,6 @@ impl Wallet {
 				config,
 				Arc::clone(&store),
 				Arc::clone(&event_queue),
-				tx_metadata.clone(),
 				Arc::clone(&logger),
 			)
 			.await?,

orange-sdk/src/lightning_wallet.rs

@@ -1,7 +1,7 @@
 use crate::bitcoin::OutPoint;
 use crate::event::{EventQueue, LdkEventHandler};
 use crate::logging::Logger;
-use crate::store::{TxMetadataStore, TxStatus};
+use crate::store::TxStatus;
 use crate::{ChainSource, InitFailure, PaymentType, Seed, WalletConfig};
 
 use bitcoin_payment_instructions::PaymentMethod;
@@ -53,7 +53,7 @@ const DEFAULT_INVOICE_EXPIRY_SECS: u32 = 86_400; // 24 hours
 impl LightningWallet {
 	pub(super) async fn init(
 		runtime: Arc<Runtime>, config: WalletConfig, store: Arc<dyn KVStore + Sync + Send>,
-		event_queue: Arc<EventQueue>, tx_metadata: TxMetadataStore, logger: Arc<Logger>,
+		event_queue: Arc<EventQueue>, logger: Arc<Logger>,
 	) -> Result<Self, InitFailure> {
 		log_info!(logger, "Creating LDK node...");
 		let anchor_channels_config = ldk_node::config::AnchorChannelsConfig {
@@ -164,7 +164,6 @@ impl LightningWallet {
 			ldk_node: Arc::clone(&ldk_node),
 			payment_receipt_sender,
 			channel_pending_sender,
-			tx_metadata,
 			logger,
 		});
 		let inner = Arc::new(LightningWalletImpl {

orange-sdk/src/trusted_wallet/dummy.rs

@@ -364,8 +364,8 @@ impl TrustedWalletInterface for DummyTrustedWallet {
 // bad assumptions properly. So we mangle the payment id a bit here to avoid collisions.
 fn mangle_payment_id(id: [u8; 32]) -> [u8; 32] {
 	let mut mangled = id;
-	for i in 0..32 {
-		mangled[i] = mangled[i].wrapping_add(0x42);
+	for i in &mut mangled {
+		*i = i.wrapping_add(0x42);
 	}
 	mangled
 }