Remove WalletBuilder - #12
Merged
Merged
Conversation
johncantrell97
force-pushed
the
remove-builder
branch
5 times, most recently
from
September 3, 2025 15:35
7cb44aa to
0d2f7d5
Compare
johncantrell97
force-pushed
the
remove-builder
branch
from
September 3, 2025 15:47
0d2f7d5 to
ba2dca1
Compare
benthecarman
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the WalletBuilder but keeps the
ExtraConfigenum. This way the Wallet still has no generics and can be initialized with a single configuration object. This simplifies the bindings.We can always reintroduce the builder if needed in the future (because we want to support building a wallet with a custom trusted wallet).