Merge pull request #4667 from jkczyz/2026-06-offer-quantity-check

Reject quantity of 0 for offers with bounded quantity

Author: TheBlueMatt

lightning/src/offers/invoice_request.rs

@@ -2221,6 +2221,19 @@ mod tests {
 			Err(e) => assert_eq!(e, Bolt12SemanticError::InvalidQuantity),
 		}
 
+		match OfferBuilder::new(recipient_pubkey())
+			.amount_msats(1000)
+			.supported_quantity(Quantity::Bounded(ten))
+			.build()
+			.unwrap()
+			.request_invoice(&expanded_key, nonce, &secp_ctx, payment_id)
+			.unwrap()
+			.quantity(0)
+		{
+			Ok(_) => panic!("expected error"),
+			Err(e) => assert_eq!(e, Bolt12SemanticError::InvalidQuantity),
+		}
+
 		let invoice_request = OfferBuilder::new(recipient_pubkey())
 			.amount_msats(1000)
 			.supported_quantity(Quantity::Unbounded)

lightning/src/offers/offer.rs

@@ -975,7 +975,7 @@ impl OfferContents {
 
 	fn is_valid_quantity(&self, quantity: u64) -> bool {
 		match self.supported_quantity {
-			Quantity::Bounded(n) => quantity <= n.get(),
+			Quantity::Bounded(n) => quantity > 0 && quantity <= n.get(),
 			Quantity::Unbounded => quantity > 0,
 			Quantity::One => quantity == 1,
 		}