Merge pull request #2611 from TheBlueMatt/2023-09-no-close-on-bad-update

Don't FC when a `channel_update` has a bogus `htlc_minimum_msat`

Author: TheBlueMatt

lightning/src/ln/channel.rs

@@ -5538,9 +5538,6 @@ impl<SP: Deref> Channel<SP> where
 	}
 
 	pub fn channel_update(&mut self, msg: &msgs::ChannelUpdate) -> Result<(), ChannelError> {
-		if msg.contents.htlc_minimum_msat >= self.context.channel_value_satoshis * 1000 {
-			return Err(ChannelError::Close("Minimum htlc value is greater than channel value".to_string()));
-		}
 		self.context.counterparty_forwarding_info = Some(CounterpartyForwardingInfo {
 			fee_base_msat: msg.contents.fee_base_msat,
 			fee_proportional_millionths: msg.contents.fee_proportional_millionths,

lightning/src/ln/channelmanager.rs

@@ -6756,7 +6756,7 @@ where
 					if were_node_one == msg_from_node_one {
 						return Ok(NotifyOption::SkipPersistNoEvents);
 					} else {
-						log_debug!(self.logger, "Received channel_update for channel {}.", chan_id);
+						log_debug!(self.logger, "Received channel_update {:?} for channel {}.", msg, chan_id);
 						try_chan_phase_entry!(self, chan.channel_update(&msg), chan_phase_entry);
 					}
 				} else {