Skip to content

Support splice shared input signing#4024

Merged
wpaulino merged 6 commits into
lightningdevkit:mainfrom
wpaulino:sign-splice-shared-input
Aug 27, 2025
Merged

Support splice shared input signing#4024
wpaulino merged 6 commits into
lightningdevkit:mainfrom
wpaulino:sign-splice-shared-input

Sign splice shared input when producing holder tx_signatures

e664b7e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 27, 2025 in 0s

88.74% (-0.03%) compared to 9724d19

View this Pull Request on Codecov

88.74% (-0.03%) compared to 9724d19

Details

Codecov Report

❌ Patch coverage is 61.42857% with 81 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.74%. Comparing base (9724d19) to head (e664b7e).
⚠️ Report is 56 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/interactivetxs.rs 59.54% 42 Missing and 11 partials ⚠️
lightning/src/sign/mod.rs 0.00% 12 Missing ⚠️
lightning/src/ln/channelmanager.rs 40.00% 8 Missing and 1 partial ⚠️
lightning/src/util/test_channel_signer.rs 0.00% 4 Missing ⚠️
lightning/src/ln/channel.rs 93.75% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4024      +/-   ##
==========================================
- Coverage   88.77%   88.74%   -0.03%     
==========================================
  Files         175      176       +1     
  Lines      127846   128638     +792     
  Branches   127846   128638     +792     
==========================================
+ Hits       113492   114164     +672     
- Misses      11788    11877      +89     
- Partials     2566     2597      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.