Skip to content

Drop Deref indirection for most trait parameters #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valentinewallace merged 16 commits into from
Jan 30, 2026

Drop Deref indirection for UtxoLookup

101d206
Select commit
Loading
Failed to load commit list.
Merged

Drop Deref indirection for most trait parameters #4311

Drop Deref indirection for UtxoLookup
101d206
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2026 in 1s

85.98% (-0.12%) compared to f9ad345

View this Pull Request on Codecov

85.98% (-0.12%) compared to f9ad345

Details

Codecov Report

❌ Patch coverage is 81.59722% with 212 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.98%. Comparing base (f9ad345) to head (101d206).

Files with missing lines Patch % Lines
lightning/src/ln/msgs.rs 35.05% 126 Missing ⚠️
lightning/src/util/persist.rs 45.94% 20 Missing ⚠️
lightning/src/ln/channel.rs 93.85% 14 Missing ⚠️
lightning/src/ln/peer_handler.rs 70.58% 9 Missing and 1 partial ⚠️
lightning-background-processor/src/lib.rs 68.18% 7 Missing ⚠️
lightning/src/chain/channelmonitor.rs 91.02% 7 Missing ⚠️
lightning/src/util/anchor_channel_reserves.rs 0.00% 6 Missing ⚠️
lightning/src/chain/chainmonitor.rs 77.77% 4 Missing ⚠️
lightning/src/onion_message/messenger.rs 92.00% 4 Missing ⚠️
lightning-net-tokio/src/lib.rs 0.00% 3 Missing ⚠️
... and 6 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4311      +/-   ##
==========================================
- Coverage   86.09%   85.98%   -0.12%     
==========================================
  Files         156      156              
  Lines      102804   102609     -195     
  Branches   102804   102609     -195     
==========================================
- Hits        88508    88225     -283     
- Misses      11788    11873      +85     
- Partials     2508     2511       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov