Skip to content

Support async signing of splice shared input#4579

Merged
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
wpaulino:async-sign-shared-input
May 13, 2026
Merged

Support async signing of splice shared input#4579
TheBlueMatt merged 1 commit into
lightningdevkit:mainfrom
wpaulino:async-sign-shared-input

Support async signing of splice shared input

f408b17
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 12, 2026 in 0s

86.15% (+0.04%) compared to 946ee09

View this Pull Request on Codecov

86.15% (+0.04%) compared to 946ee09

Details

Codecov Report

❌ Patch coverage is 89.61039% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.15%. Comparing base (946ee09) to head (f408b17).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 90.90% 4 Missing and 5 partials ⚠️
lightning/src/ln/interactivetxs.rs 84.90% 6 Missing and 2 partials ⚠️
lightning/src/ln/channelmanager.rs 91.66% 3 Missing and 3 partials ⚠️
lightning/src/util/test_channel_signer.rs 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #4579      +/-   ##
==========================================
+ Coverage   86.11%   86.15%   +0.04%     
==========================================
  Files         157      157              
  Lines      108841   109096     +255     
  Branches   108841   109096     +255     
==========================================
+ Hits        93725    93989     +264     
+ Misses      12497    12485      -12     
- Partials     2619     2622       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov