Skip to content

[0.1] Fix MSRV compatibility#4737

Open
TheBlueMatt wants to merge 3 commits into
lightningdevkit:0.1from
TheBlueMatt:2026-06-0.1-msrv
Open

[0.1] Fix MSRV compatibility#4737
TheBlueMatt wants to merge 3 commits into
lightningdevkit:0.1from
TheBlueMatt:2026-06-0.1-msrv

Conversation

@TheBlueMatt

Copy link
Copy Markdown
Collaborator

8a39057 broke MSRV for 0.1 which is still 1.63. We fix it here.

8a39057 broke MSRV for 0.1 which
is still 1.63. We fix it here.
@ldk-reviews-bot

ldk-reviews-bot commented Jun 23, 2026

Copy link
Copy Markdown

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-claude-review-bot

ldk-claude-review-bot commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

No issues found.

The diff is identical to my prior review pass. The changes are straightforward MSRV CI dependency pins and a semantically-equivalent is_some_and(|key| ...)map(|key| ...).unwrap_or(false) replacement (since Option::is_some_and requires Rust 1.70+, above the 0.1 MSRV of 1.63), plus removal of now-unused imports in offers_tests.rs and peer_handler.rs.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.54%. Comparing base (b6f3ad7) to head (5b72cd4).

Additional details and impacted files
@@           Coverage Diff           @@
##              0.1    #4737   +/-   ##
=======================================
  Coverage   84.54%   84.54%           
=======================================
  Files         137      137           
  Lines       77617    77617           
  Branches    77617    77617           
=======================================
  Hits        65625    65625           
+ Misses       9949     9944    -5     
- Partials     2043     2048    +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheBlueMatt TheBlueMatt force-pushed the 2026-06-0.1-msrv branch 3 times, most recently from 58363d9 to 5b72cd4 Compare June 23, 2026 01:49

@tnull tnull left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing.

@TheBlueMatt TheBlueMatt force-pushed the 2026-06-0.1-msrv branch 4 times, most recently from 7f7bd9f to def6a1b Compare June 23, 2026 14:40
@valentinewallace

Copy link
Copy Markdown
Contributor

CI still failing

@TheBlueMatt

Copy link
Copy Markdown
Collaborator Author

I believe this is correct now. CI is now dependent on itself (its failing to build the release 0.1.10 lightning crate). rustfmt/linting/fuzz/build-tx-sync are legit-broken, but those aren't required to fix bindings.

@valentinewallace

Copy link
Copy Markdown
Contributor

Should we go ahead and fix those checks? Otherwise, we're committing to those checks failing on 0.1, etc branches moving forward?

@TheBlueMatt

Copy link
Copy Markdown
Collaborator Author

Both linting and rustfmt have been failing for a while, in the lint case because it targets rustc stable and thus is a moving target. I believe I've fixed the others (except the one that depends on 0.1 itself).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants