Bump MSRV and reqwest dependency#38
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
d886342 to
455e666
Compare
455e666 to
c5599bc
Compare
tnull
changed the title
reqwest, enable client-side timeoutsreqwest dependency
Hmm, not sure tbh? Do you think we should? Also, should we add a CI that runs |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
Hmm, not sure tbh? Do you think we should?
Upon further thought, I don't think it's necessary since this is a developer command; first update API definition, then update src/types.rs.
Also, should we add a CI that runs genproto and checks the output is up-to-date, i.e., requiring any PRs going forward to update the types.rs as we go, similar to running rustfmt?
Certainly yes - I'll take care of this in a follow-up thank you.
3 participants
We bump the MSRV to 1.75.0 as most of our HTTP dependencies already require this, and we already require it for
lightning-transaction-sync/ LDK Node.As we can do this then, we bump the
reqwestdependency to 0.12 (which is nice as most other projects have by now, allowing us to not keep multiple versions in the tree).