Skip to content

Commit 8e1ff9a

Browse files
committed
Add vss_client_v050_compatibility test
We recently added the requirement that VSS servers return key-version lists in creation order. We also added a version header to all VSS responses such that clients requiring creation-order lists can ensure the VSS server they talk to provides this guarantee. These VSS server changes remain fully backwards compatible with previously-released VSS clients. Here we add a test that ensures that this is true against the last VSS client release made prior to these changes. This new test also makes sure that any future changes to VSS server remain backwards compatible with VSS client v0.5.0. AI wrote the test.
1 parent f728209 commit 8e1ff9a

7 files changed

Lines changed: 559 additions & 8 deletions

File tree

.github/workflows/impl_tests.yml renamed to .github/workflows/implementation-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,14 @@ concurrency:
77
cancel-in-progress: true
88

99
jobs:
10-
test-postgres-backend:
10+
postgres-backend-tests:
1111
strategy:
1212
fail-fast: false
1313
matrix:
1414
platform: [ ubuntu-latest ]
1515
toolchain: [ stable, 1.85.0 ] # 1.85.0 is the MSRV
1616
runs-on: ${{ matrix.platform }}
17+
timeout-minutes: 15
1718

1819
services:
1920
postgres:

.github/workflows/ldk-node-integration.yml renamed to .github/workflows/ldk-node-integration-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ concurrency:
77
cancel-in-progress: true
88

99
jobs:
10-
build-and-test:
10+
ldk-node-integration-tests:
1111
strategy:
1212
fail-fast: false
1313
matrix:

.github/workflows/build-and-deploy-rust.yml renamed to .github/workflows/ping-tests.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Ping Check
1+
name: Ping Tests
22

33
on: [push, pull_request]
44

@@ -7,13 +7,14 @@ concurrency:
77
cancel-in-progress: true
88

99
jobs:
10-
ping-check:
10+
ping-tests:
1111
strategy:
1212
fail-fast: false
1313
matrix:
1414
platform: [ ubuntu-latest ]
1515
toolchain: [ stable, 1.85.0 ] # 1.85.0 is the MSRV
1616
runs-on: ${{ matrix.platform }}
17+
timeout-minutes: 15
1718

1819
services:
1920
postgres:

.github/workflows/server-tests.yml

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
name: Server Tests
2+
3+
on: [push, pull_request]
4+
5+
concurrency:
6+
group: ${{ github.workflow }}-${{ github.ref }}
7+
cancel-in-progress: true
8+
9+
jobs:
10+
server-tests:
11+
strategy:
12+
fail-fast: false
13+
matrix:
14+
platform: [ ubuntu-latest ]
15+
toolchain: [ stable, 1.85.0 ] # 1.85.0 is the MSRV
16+
runs-on: ${{ matrix.platform }}
17+
timeout-minutes: 15
18+
19+
services:
20+
postgres:
21+
image: postgres:latest
22+
ports:
23+
- 5432:5432
24+
env:
25+
POSTGRES_DB: postgres
26+
POSTGRES_USER: postgres
27+
POSTGRES_PASSWORD: postgres
28+
options: >-
29+
--health-cmd pg_isready
30+
--health-interval 10s
31+
--health-timeout 5s
32+
--health-retries 5
33+
34+
steps:
35+
- name: Checkout code
36+
uses: actions/checkout@v3
37+
- name: Build and Deploy VSS Server
38+
run: |
39+
cd rust
40+
RUSTFLAGS="--cfg noop_authorizer" cargo build --no-default-features
41+
./target/debug/vss-server server/vss-server-config.toml&
42+
- name: Run the server tests
43+
run: |
44+
sleep 5
45+
cd rust/server
46+
cargo test

rust/Cargo.lock

Lines changed: 178 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)