fixup: use the unit type to return an error from jwt setup

there is only one possible error here so keep things simple for now

Author: tankyleo

rust/auth-impls/src/jwt.rs

@@ -36,23 +36,22 @@ pub(crate) struct Claims {
 
 const BEARER_PREFIX: &str = "Bearer ";
 
-fn parse_public_key_pem(pem: &str) -> Result<PKey<Public>, String> {
+fn parse_public_key_pem(pem: &str) -> Result<PKey<Public>, ()> {
 	let body = pem
 		.trim()
 		.strip_prefix("-----BEGIN PUBLIC KEY-----")
-		.ok_or(String::from("Prefix not found"))?
+		.ok_or(())?
 		.strip_suffix("-----END PUBLIC KEY-----")
-		.ok_or(String::from("Suffix not found"))?;
+		.ok_or(())?;
 	let body: String = body.lines().map(|line| line.trim()).collect();
-	let body = STANDARD.decode(body).map_err(|_| String::from("Base64 decode failed"))?;
-	PKey::public_key_from_der(&body).map_err(|_| String::from("DER decode failed"))
+	let body = STANDARD.decode(body).map_err(|_| ())?;
+	PKey::public_key_from_der(&body).map_err(|_| ())
 }
 
 impl JWTAuthorizer {
 	/// Creates a new instance of [`JWTAuthorizer`], fails on failure to parse the PEM formatted RSA public key
-	pub async fn new(rsa_pem: &str) -> Result<Self, String> {
-		let jwt_issuer_key = parse_public_key_pem(rsa_pem)
-			.map_err(|e| format!("Failed to parse the PEM formatted RSA public key: {}", e))?;
+	pub async fn new(rsa_pem: &str) -> Result<Self, ()> {
+		let jwt_issuer_key = parse_public_key_pem(rsa_pem)?;
 		Ok(Self { jwt_issuer_key })
 	}
 }

rust/server/src/main.rs

@@ -86,8 +86,8 @@ fn main() {
 						info!("Configured JWT authorizer with RSA public key");
 						Some(Arc::new(auth))
 					},
-					Err(e) => {
-						error!("Failed to configure JWT authorizer: {}", e);
+					Err(()) => {
+						error!("Failed to configure JWT authorizer");
 						std::process::exit(-1);
 					},
 				};