Add rustfmt to CI to ensure formatting is checked#66
Conversation
|
👋 I see @tankyleo was un-assigned. |
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
LGTM, reproduced on my machine, two questions
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Check formatting on Rust ${{ matrix.toolchain }} | ||
| if: matrix.check-fmt |
There was a problem hiding this comment.
Ah, lol, good catch. It would be if I checked in the change. For simplicity I now simply dropped the line.
There was a problem hiding this comment.
It would be if I checked in the change.
Can you clarify this ? Thank you :)
There was a problem hiding this comment.
I am also unclear how ${{ matrix.toolchain }} gets defined, thank you for the clarification.
There was a problem hiding this comment.
🤦♂️ Sorry, that variable is likely only available if you use a matrix strategy in the workflow, see https://docs.github.com/en/actions/how-tos/write-workflows/choose-what-workflows-do/run-job-variations
Now dropped it.
It would be if I checked in the change.
Can you clarify this ? Thank you :)
Yes, I previously made/copy pasted some changes that weren't fully making it here. However, for now it's probably better to keep it simple anyways.
tnull
force-pushed
the
2025-11-rustfmt
branch
from
0867dac to
5d714c8
Compare
.. we simply add a `cargo fmt` step to our Rust CI
tnull
force-pushed
the
2025-11-rustfmt
branch
from
5d714c8 to
b6b3ff6
Compare
3 participants
.. we simply add a
cargo fmtstep to our Rust CI